Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-17 Thread Het Gala
On 17/01/23 4:17 pm, Dr. David Alan Gilbert wrote: * Het Gala (het.g...@nutanix.com) wrote: From: Author Het Gala Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri' parameter. Th

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-17 Thread Het Gala
On 17/01/23 4:13 pm, Dr. David Alan Gilbert wrote: * Daniel P. Berrangé (berra...@redhat.com) wrote: On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote: From: Author Het Gala Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and correspon

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-17 Thread Dr. David Alan Gilbert
* Het Gala (het.g...@nutanix.com) wrote: > From: Author Het Gala > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > of destination interface and corresponding port number in the form > of a unified string 'uri' parameter. This scheme does seem to have an issue > in it,

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-17 Thread Dr. David Alan Gilbert
* Daniel P. Berrangé (berra...@redhat.com) wrote: > On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote: > > From: Author Het Gala > > > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > > of destination interface and corresponding port number in the form > > of a u

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-13 Thread Daniel P . Berrangé
On Fri, Jan 13, 2023 at 01:37:26PM +0530, Het Gala wrote: > > On 09/01/23 7:37 pm, Daniel P. Berrangé wrote: > > On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote: > > > From: Author Het Gala > > > > > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > > > of dest

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-13 Thread Het Gala
On 09/01/23 7:37 pm, Daniel P. Berrangé wrote: On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote: From: Author Het Gala Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri'

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-10 Thread Het Gala
On 10/01/23 3:02 pm, Daniel P. Berrangé wrote: On Tue, Jan 10, 2023 at 01:09:35PM +0530, Het Gala wrote: On 09/01/23 7:37 pm, Daniel P. Berrangé wrote: Loooking at the RDMA code it takes the str, and treats it as an IPv4 address: addr = g_new(InetSocketAddress, 1); if (

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-10 Thread Daniel P . Berrangé
On Tue, Jan 10, 2023 at 01:09:35PM +0530, Het Gala wrote: > > On 09/01/23 7:37 pm, Daniel P. Berrangé wrote: > > On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote: > > > From: Author Het Gala > > > > > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > > > of dest

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-09 Thread Het Gala
On 09/01/23 7:37 pm, Daniel P. Berrangé wrote: On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote: From: Author Het Gala Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri'

Re: [PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2023-01-09 Thread Daniel P . Berrangé
On Mon, Dec 26, 2022 at 05:33:25AM +, Het Gala wrote: > From: Author Het Gala > > Existing 'migrate' QAPI design enforces transport mechanism, ip address > of destination interface and corresponding port number in the form > of a unified string 'uri' parameter. This scheme does seem to have a

[PATCH 1/5] migration: Updated QAPI format for 'migrate' qemu monitor command

2022-12-25 Thread Het Gala
From: Author Het Gala Existing 'migrate' QAPI design enforces transport mechanism, ip address of destination interface and corresponding port number in the form of a unified string 'uri' parameter. This scheme does seem to have an issue in it, i.e. double-level encoding of URIs. The current patc