On 10/01/23 3:02 pm, Daniel P. Berrangé wrote:
On Tue, Jan 10, 2023 at 01:09:35PM +0530, Het Gala wrote:
On 09/01/23 7:37 pm, Daniel P. Berrangé wrote:
Loooking at the RDMA code it takes the str, and treats it
as an IPv4 address:
addr = g_new(InetSocketAddress, 1);
if (!inet_parse(addr, host_port, NULL)) {
rdma->port = atoi(addr->port);
rdma->host = g_strdup(addr->host);
rdma->host_port = g_strdup(host_port);
}
so we really ought to accept an InetSocketAddress struct
directly
{ 'struct': 'MigrateRdmaAddr',
'data' : {'rdma-str': 'InetSocketAddress' } }
Yes, It resembles to InetSocketAddress. Will make the relevant changes in
rdma.c file.
With this, I had a small question in mind, do qemu need to develop /
leverage some functionality to check the correctness for host or port.
So that if the user enters an invalid host address, they get an error
message to enter correct address, if trying to migrate via qmp command line
interface.
When the RDMA code uses the host address to resolve the RDMA
endpoint, it will fail and report an error back.
With regards,
Daniel
Okay, understood. Thanks for the explanation Daniel
Regards,
Het Gala
