Re: [PATCH 1/5] hw/arm/smmuv3: Apply address mask to linear strtab base address

2019-12-09 Thread Auger Eric
Hi Simon, On 12/5/19 11:04 PM, Simon Veith wrote: > Hello Eric, > > On 05/12/2019 09:42, Auger Eric wrote: >> Not related to this patch but I noticed SMMU_BASE_ADDR_MASK should be >> 0xffc0 and not 0xffe0. I can fix it separately or if you >> respin, you may fix it as well? > > G

Re: [PATCH 1/5] hw/arm/smmuv3: Apply address mask to linear strtab base address

2019-12-05 Thread Simon Veith
Hello Eric, On 05/12/2019 09:42, Auger Eric wrote: > Not related to this patch but I noticed SMMU_BASE_ADDR_MASK should be > 0xffc0 and not 0xffe0. I can fix it separately or if you > respin, you may fix it as well? Good catch, thank you. I'll fix it in the next version. Looking

Re: [PATCH 1/5] hw/arm/smmuv3: Apply address mask to linear strtab base address

2019-12-05 Thread Auger Eric
Hi Simon, On 12/4/19 2:55 PM, Simon Veith wrote: > In the SMMU_STRTAB_BASE register, the stream table base address only > occupies bits [51:6]. Other bits, such as RA (bit [62]), must be masked > out to obtain the base address. > > The branch for 2-level stream tables correctly applies this mask

[PATCH 1/5] hw/arm/smmuv3: Apply address mask to linear strtab base address

2019-12-04 Thread Simon Veith
In the SMMU_STRTAB_BASE register, the stream table base address only occupies bits [51:6]. Other bits, such as RA (bit [62]), must be masked out to obtain the base address. The branch for 2-level stream tables correctly applies this mask by way of SMMU_BASE_ADDR_MASK, but the one for linear stream