Re: [PATCH 1/2] dump: simplify a bit kdump get_next_page()

2022-08-26 Thread Marc-André Lureau
Hi On Fri, Aug 26, 2022 at 1:45 PM David Hildenbrand wrote: > > On 25.08.22 15:21, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > This should be functionally equivalent, but slightly easier to read, > > with simplified paths and checks at the end of the function. > > > >

Re: [PATCH 1/2] dump: simplify a bit kdump get_next_page()

2022-08-26 Thread David Hildenbrand
On 26.08.22 11:56, Marc-André Lureau wrote: > Hi > > On Fri, Aug 26, 2022 at 1:45 PM David Hildenbrand wrote: >> >> On 25.08.22 15:21, marcandre.lur...@redhat.com wrote: >>> From: Marc-André Lureau >>> >>> This should be functionally equivalent, but slightly easier to read, >>> with simplified p

Re: [PATCH 1/2] dump: simplify a bit kdump get_next_page()

2022-08-26 Thread David Hildenbrand
On 25.08.22 15:21, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > This should be functionally equivalent, but slightly easier to read, > with simplified paths and checks at the end of the function. > > The following patch is a major rewrite to get rid of the assert(). > > Sign

[PATCH 1/2] dump: simplify a bit kdump get_next_page()

2022-08-25 Thread marcandre . lureau
From: Marc-André Lureau This should be functionally equivalent, but slightly easier to read, with simplified paths and checks at the end of the function. The following patch is a major rewrite to get rid of the assert(). Signed-off-by: Marc-André Lureau --- dump/dump.c | 30 --