Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-10-08 Thread Gao,Shiyuan
> >> > diff --git a/hw/pci/pci_bridge.c b/hw/pci/pci_bridge.c index > >> > 6a4e38856d..74683e7445 100644 > >> > --- a/hw/pci/pci_bridge.c > >> > +++ b/hw/pci/pci_bridge.c > >> > @@ -380,6 +380,7 @@ void pci_bridge_initfn(PCIDevice *dev, const char > >> *typename) > >> > sec_bus->map_irq = br->map_i

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-10-08 Thread Junjie Mao
"Zuo,Boqun" writes: > On Wed, Sep 25, 2024 8:58 PM Junjie Mao wrote: >> > As shown below, if a virtio PCI device is attached under a pci-bridge, >> > the MR of VirtIOPCIRegion does not belong to any address space. So >> > memory_region_find cannot be used to search for this MR. >> > >> > Introd

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-10-08 Thread David Hildenbrand
On 30.09.24 16:00, Michael S. Tsirkin wrote: On Tue, Sep 24, 2024 at 02:31:20PM +0200, David Hildenbrand wrote: On 24.09.24 03:11, Gao Shiyuan wrote: Make sure to version your patch series. For example, via $ git format-patch -v1 ... As shown below, if a virtio PCI device is attached

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-10-07 Thread Zuo,Boqun
On Wed, Sep 25, 2024 8:58 PM Junjie Mao wrote: > > As shown below, if a virtio PCI device is attached under a pci-bridge, > > the MR of VirtIOPCIRegion does not belong to any address space. So > > memory_region_find cannot be used to search for this MR. > > > > Introduce the virtio-pci and pci_br

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-30 Thread Michael S. Tsirkin
On Tue, Sep 24, 2024 at 02:31:20PM +0200, David Hildenbrand wrote: > On 24.09.24 03:11, Gao Shiyuan wrote: > > Make sure to version your patch series. For example, via > $ git format-patch -v1 ... > > > As shown below, if a virtio PCI device is attached under a pci-bridge, the > > MR > > o

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-25 Thread Junjie Mao
Gao Shiyuan via writes: > As shown below, if a virtio PCI device is attached under a pci-bridge, the MR > of VirtIOPCIRegion does not belong to any address space. So memory_region_find > cannot be used to search for this MR. > > Introduce the virtio-pci and pci_bridge_pci address spaces to solv

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-25 Thread Junjie Mao
"Gao,Shiyuan" via writes: >> > >> > Introduce the virtio-pci and pci_bridge_pci address spaces to solve this >> > problem. >> > >> > Before: >> > memory-region: pci_bridge_pci >> >    - (prio 0, i/o): pci_bridge_pci >> >  fe20-fe200fff (pr

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-24 Thread Gao,Shiyuan
> Make sure to version your patch series. For example, via >     $ git format-patch -v1 ... Thanks, the first version forgot to CC qemu-devel, I resent it. I'll add version to next version. > > > As shown below, if a virtio PCI device is attached under a pci-bridge, the > > MR > > of VirtIO

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-24 Thread David Hildenbrand
On 24.09.24 03:11, Gao Shiyuan wrote: Make sure to version your patch series. For example, via $ git format-patch -v1 ... As shown below, if a virtio PCI device is attached under a pci-bridge, the MR of VirtIOPCIRegion does not belong to any address space. So memory_region_find cannot b

[PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-23 Thread Gao Shiyuan via
As shown below, if a virtio PCI device is attached under a pci-bridge, the MR of VirtIOPCIRegion does not belong to any address space. So memory_region_find cannot be used to search for this MR. Introduce the virtio-pci and pci_bridge_pci address spaces to solve this problem. Before: memory-regi