On 23/01/21 03:05, Brian Norris wrote:
It turns out that Paolo inadvertently (?) fixed this issue by
refactoring, in v5.2.0:
ea1edcd7da1a vl: relocate paths to data directories
https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ea1edcd7da1a375ef7ccf8aa93b72827b518ad8e;hp=63c4db4c2e6d221cecb5aafa3659
Just to follow-up here, since nobody followed up for months...
On Mon, Aug 10, 2020 at 2:41 PM Brian Norris wrote:
> On Mon, Aug 10, 2020 at 12:29 AM Marc-André Lureau
> wrote:
> > On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell
> > wrote:
> > > On Sat, 8 Aug 2020 at 02:35, Brian Norris
> > > w
On Mon, Aug 10, 2020 at 12:29 AM Marc-André Lureau
wrote:
> On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell wrote:
> > On Sat, 8 Aug 2020 at 02:35, Brian Norris wrote:
> > > Add one more to the pile! Chrome OS noticed this when upgrading to
> > > 5.0.0:
> > >
> > > https://bugs.chromium.org/p/chrom
On Tue, Jun 16, 2020 at 2:59 AM Joe Slater wrote:
> Always look for ../share/qemu then ../pc-bios when looking for datadir.
>
> Signed-off-by: Joe Slater
>
Reviewed-by: Marc-André Lureau
---
> os-posix.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/os-posi
Hi
On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell wrote:
>
> On Sat, 8 Aug 2020 at 02:35, Brian Norris wrote:
> >
> > Hello!
> >
> > On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote:
> > > Hi
> > >
> > > On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell
> > > wrote:
> > > >
> > > >
On Sat, 8 Aug 2020 at 02:35, Brian Norris wrote:
>
> Hello!
>
> On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote:
> > Hi
> >
> > On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell
> > wrote:
> > >
> > > On Tue, 16 Jun 2020 at 10:19, Peter Maydell
> > > wrote:
> > > >
> > > > On Tu
Hello!
On Wed, Jul 15, 2020 at 11:57:14PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell
> wrote:
> >
> > On Tue, 16 Jun 2020 at 10:19, Peter Maydell
> > wrote:
> > >
> > > On Tue, 16 Jun 2020 at 00:00, Joe Slater wrote:
> > > >
> > > > Always look fo
Hi
On Tue, Jun 16, 2020 at 2:59 AM Joe Slater wrote:
> Always look for ../share/qemu then ../pc-bios when looking for datadir.
>
> Signed-off-by: Joe Slater
>
Looks good to me, with:
Fixes: 6dd2dacedd83d12328 ("os-posix: simplify os_find_datadir")
Reviewed-by: Marc-André Lureau
Alternatively
Hi
On Wed, Jul 15, 2020 at 11:37 PM Peter Maydell wrote:
>
> On Tue, 16 Jun 2020 at 10:19, Peter Maydell wrote:
> >
> > On Tue, 16 Jun 2020 at 00:00, Joe Slater wrote:
> > >
> > > Always look for ../share/qemu then ../pc-bios when looking for datadir.
> >
> > Could you provide some more context
On Tue, 16 Jun 2020 at 10:19, Peter Maydell wrote:
>
> On Tue, 16 Jun 2020 at 00:00, Joe Slater wrote:
> >
> > Always look for ../share/qemu then ../pc-bios when looking for datadir.
>
> Could you provide some more context, please? Why is this
> change useful; presumably we broke some setup in 5.
h
command line options taking precedence.
Joe
-Original Message-
From: Peter Maydell
Sent: Tuesday, June 16, 2020 2:20 AM
To: Slater, Joseph
Cc: QEMU Developers ; MacLeod, Randy
; Marc-André Lureau ;
Paolo Bonzini
Subject: Re: [PATCH 1/1] os_find_datadir: search as in version 4.2
On Tue, 16 Jun 2020 at 00:00, Joe Slater wrote:
>
> Always look for ../share/qemu then ../pc-bios when looking for datadir.
Could you provide some more context, please? Why is this
change useful; presumably we broke some setup in 5.0, but
what exactly ?
I'm guessing this might be a regression in
Always look for ../share/qemu then ../pc-bios when looking for datadir.
Signed-off-by: Joe Slater
---
os-posix.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/os-posix.c b/os-posix.c
index 3cd52e1e70..f77da94bf6 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -82,8 +82,
13 matches
Mail list logo
