Just to follow-up here, since nobody followed up for months... On Mon, Aug 10, 2020 at 2:41 PM Brian Norris <briannor...@chromium.org> wrote: > On Mon, Aug 10, 2020 at 12:29 AM Marc-André Lureau > <marcandre.lur...@redhat.com> wrote: > > On Sat, Aug 8, 2020 at 7:34 PM Peter Maydell <peter.mayd...@linaro.org> > > wrote: > > > On Sat, 8 Aug 2020 at 02:35, Brian Norris <briannor...@chromium.org> > > > wrote: > > > It's just missed 5.1, unfortunately :-(
And it missed 5.2 too :( > > > Marc-André, did you want to review it ? > > > > I tried an alternative approach, and ack his version instead: > > > > https://patchew.org/QEMU/20200716141100.398296-1-marcandre.lur...@redhat.com/ > > > > (I am going to do this in this thread instead) > > FWIW, you already provided your Review a month ago: > https://lore.kernel.org/qemu-devel/caj+f1cjmmv6py6r0p6uknza_q+w6ylvaxekgnusgxyuuip6...@mail.gmail.com/ > > But I see you've now repeated it ;) > https://lore.kernel.org/qemu-devel/caj+f1cjdho7r9rnmod1clezsylfsfvvjcar5ucsyfgfcw3z...@mail.gmail.com/ > > In any case, thanks! We'll likely carry this patch in Chrome OS, until > it gets applied to a proper release. It turns out that Paolo inadvertently (?) fixed this issue by refactoring, in v5.2.0: ea1edcd7da1a vl: relocate paths to data directories https://git.qemu.org/?p=qemu.git;a=commitdiff;h=ea1edcd7da1a375ef7ccf8aa93b72827b518ad8e;hp=63c4db4c2e6d221cecb5aafa365934bb05724cb4 I tested that out here, and the new find_datadir() is able to track relocations properly, by looking for a common directory ancestor of the running executable. Thanks Paolo! Brian
