Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI

2022-11-28 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when > >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when > >> !CONFIG_PCI. Build pci-h

Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI

2022-11-28 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when >> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too. >> >> Signed-off-by: Markus Armbr

Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI

2022-11-28 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when > CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when > !CONFIG_PCI. Build pci-hmp-cmds.c that way, too. > > Signed-off-by: Markus Armbruster Had you considered wrapping the hm

Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI

2022-11-28 Thread Michael S. Tsirkin
On Mon, Nov 28, 2022 at 11:21:36AM +0100, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > > > On 28/11/22 09:01, Markus Armbruster wrote: > >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when > >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when > >> !CONFIG_PC

Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI

2022-11-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 28/11/22 09:01, Markus Armbruster wrote: >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when >> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too. >> Signed-off-by: Markus Armbruster >>

Re: [PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI

2022-11-28 Thread Philippe Mathieu-Daudé
On 28/11/22 09:01, Markus Armbruster wrote: We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when !CONFIG_PCI. Build pci-hmp-cmds.c that way, too. Signed-off-by: Markus Armbruster --- hw/pci/pci-stub.c | 5 + hw/pci/me

[PATCH 05/12] pci: Build hw/pci/pci-hmp-cmds.c only when CONFIG_PCI

2022-11-28 Thread Markus Armbruster
We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when !CONFIG_PCI. Build pci-hmp-cmds.c that way, too. Signed-off-by: Markus Armbruster --- hw/pci/pci-stub.c | 5 + hw/pci/meson.build | 2 +- 2 files changed, 6 insertions(