On Mon, Nov 28, 2022 at 11:21:36AM +0100, Markus Armbruster wrote: > Philippe Mathieu-Daudé <phi...@linaro.org> writes: > > > On 28/11/22 09:01, Markus Armbruster wrote: > >> We compile pci-hmp-cmds.c always, but pci-qmp-cmds.c only when > >> CONFIG_PCI. hw/pci/pci-stub.c keeps the linker happy when > >> !CONFIG_PCI. Build pci-hmp-cmds.c that way, too. > >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > >> --- > >> hw/pci/pci-stub.c | 5 +++++ > >> hw/pci/meson.build | 2 +- > >> 2 files changed, 6 insertions(+), 1 deletion(-) > > > > Squash with patch #3? > > Could do, but the combined patch isn't pure code motion anymore, and I > get to explain that in the commit message.
Yes I like it the way it is. -- MST
