Re: [PATCH 05/10] rust: pl011: pull interrupt updates out of read/write ops

2025-01-22 Thread Paolo Bonzini
Il mer 22 gen 2025, 17:31 Zhao Liu ha scritto: > > if event == bindings::QEMUChrEvent::CHR_EVENT_BREAK && > !self.loopback_enabled() { > > -self.put_fifo(registers::Data::BREAK.into()); > > +let update = self.put_fifo(registers::Data::BREAK.into()); > > We can omi

Re: [PATCH 05/10] rust: pl011: pull interrupt updates out of read/write ops

2025-01-22 Thread Zhao Liu
On Fri, Jan 17, 2025 at 10:26:52AM +0100, Paolo Bonzini wrote: > Date: Fri, 17 Jan 2025 10:26:52 +0100 > From: Paolo Bonzini > Subject: [PATCH 05/10] rust: pl011: pull interrupt updates out of > read/write ops > X-Mailer: git-send-email 2.47.1 > > qemu_irqs are no

[PATCH 05/10] rust: pl011: pull interrupt updates out of read/write ops

2025-01-17 Thread Paolo Bonzini
qemu_irqs are not part of the vmstate, therefore they will remain in PL011State. Update them if needed after regs_read()/regs_write(). Apply #[must_use] to functions that return whether the interrupt state could have changed, so that it's harder to forget the call to update(). Signed-off-by: Pao