Re: [PATCH 05/10] rust: pl011: pull interrupt updates out of read/write ops

[Paolo Bonzini]

Il mer 22 gen 2025, 17:31 Zhao Liu <zhao1....@intel.com> ha scritto:

> >          if event == bindings::QEMUChrEvent::CHR_EVENT_BREAK &&
> !self.loopback_enabled() {
> > -            self.put_fifo(registers::Data::BREAK.into());
> > +            let update = self.put_fifo(registers::Data::BREAK.into());
>
> We can omit this `update` variable.
>

Indeed, but sometimes I left it because of long lines or to clarify the
meaning of the "bool" (or both).

Paolo

Reviewed-by: Zhao Liu <zhao....@intel.com>