Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191025022553.25298-1-ehabk...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions Type: series Message-id

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread David Hildenbrand
I once was told that if a user actually specified an explicit CPU model in the libvirt XML ("haswell-whatever"), you should not go ahead and make any later changes to that model (guest ABI should not change when you update/restart the guest ...). So this only applies when creating new guests? Or w

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread Daniel P . Berrangé
On Fri, Oct 25, 2019 at 04:23:59PM +0200, David Hildenbrand wrote: > > > > For example > > > > -machine s390-virtio-ccw-3.1 -cpu z14 will not have the multiple epoch > > > > facility > > > > and > > > > -machine s390-virtio-ccw-4.0 -cpu z14 will have the multiple epoch > > > > facility. > > > > A

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread David Hildenbrand
For example -machine s390-virtio-ccw-3.1 -cpu z14 will not have the multiple epoch facility and -machine s390-virtio-ccw-4.0 -cpu z14 will have the multiple epoch facility. As migration does always require the tuple of machine and cpu this is save. I fail to see what the benefit of an explicit z1

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread David Hildenbrand
On 25.10.19 15:38, Eduardo Habkost wrote: CCing danpb, libvir-list, mskrivanek. On Fri, Oct 25, 2019 at 09:17:46AM +0200, David Hildenbrand wrote: On 25.10.19 04:25, Eduardo Habkost wrote: We had introduced versioned CPU models in QEMU 4.1, including a method for querying for CPU model version

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread Daniel P . Berrangé
On Fri, Oct 25, 2019 at 10:02:29AM +0200, David Hildenbrand wrote: > On 25.10.19 09:55, Christian Borntraeger wrote: > > > > > > On 25.10.19 09:17, David Hildenbrand wrote: > > > On 25.10.19 04:25, Eduardo Habkost wrote: > > > > We had introduced versioned CPU models in QEMU 4.1, including a > >

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread Eduardo Habkost
CCing mskrivanek, danpb, libvir-list. On Fri, Oct 25, 2019 at 10:02:29AM +0200, David Hildenbrand wrote: > On 25.10.19 09:55, Christian Borntraeger wrote: > > > > > > On 25.10.19 09:17, David Hildenbrand wrote: > > > On 25.10.19 04:25, Eduardo Habkost wrote: > > > > We had introduced versioned C

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread Eduardo Habkost
CCing danpb, libvir-list, mskrivanek. On Fri, Oct 25, 2019 at 09:17:46AM +0200, David Hildenbrand wrote: > On 25.10.19 04:25, Eduardo Habkost wrote: > > We had introduced versioned CPU models in QEMU 4.1, including a > > method for querying for CPU model versions using > > Interesting, I was not

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread David Hildenbrand
On 25.10.19 09:55, Christian Borntraeger wrote: On 25.10.19 09:17, David Hildenbrand wrote: On 25.10.19 04:25, Eduardo Habkost wrote: We had introduced versioned CPU models in QEMU 4.1, including a method for querying for CPU model versions using Interesting, I was not aware of that. On s3

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread Christian Borntraeger
On 25.10.19 09:17, David Hildenbrand wrote: > On 25.10.19 04:25, Eduardo Habkost wrote: >> We had introduced versioned CPU models in QEMU 4.1, including a >> method for querying for CPU model versions using > > Interesting, I was not aware of that. > > On s390x, we somewhat have versioned CPU

Re: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-25 Thread David Hildenbrand
On 25.10.19 04:25, Eduardo Habkost wrote: We had introduced versioned CPU models in QEMU 4.1, including a method for querying for CPU model versions using Interesting, I was not aware of that. On s390x, we somewhat have versioned CPU models, but we decided against giving them explicit names (

[PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions

2019-10-24 Thread Eduardo Habkost
We had introduced versioned CPU models in QEMU 4.1, including a method for querying for CPU model versions using query-cpu-definitions. This only has one problem: fetching CPU alias information for multiple machine types required restarting QEMU for each machine being queried. This series adds a