Patchew URL: https://patchew.org/QEMU/20191025022553.25298-1-ehabk...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH 0/7] i386: Add `machine` parameter to query-cpu-definitions Type: series Message-id: 20191025022553.25298-1-ehabk...@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 80774f3 cpu: Add `machine` parameter to query-cpu-definitions a94469e i386: Don't use default_cpu_version() inside query-cpu-definitions 9c82004 i386: Remove x86_cpu_set_default_version() function c529624 machine: machine_find_class() function f79edfc i386: Don't use default_cpu_version at "-cpu help" 0106983 i386: Add default_version parameter to CPU version functions d6a172b i386: Use g_autofree at x86_cpu_list_entry() === OUTPUT BEGIN === 1/7 Checking commit d6a172b05619 (i386: Use g_autofree at x86_cpu_list_entry()) 2/7 Checking commit 0106983c7b3c (i386: Add default_version parameter to CPU version functions) WARNING: line over 80 characters #28: FILE: target/i386/cpu.c:3191: + X86CPUVersion default_version) WARNING: line over 80 characters #60: FILE: target/i386/cpu.c:3983: + g_autofree char *alias_of = x86_cpu_class_get_alias_of(cc, default_cpu_version); WARNING: line over 80 characters #78: FILE: target/i386/cpu.c:4121: + X86CPUVersion version = x86_cpu_model_resolve_version(model, default_cpu_version); total: 0 errors, 3 warnings, 55 lines checked Patch 2/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/7 Checking commit f79edfcd6195 (i386: Don't use default_cpu_version at "-cpu help") 4/7 Checking commit c529624d287b (machine: machine_find_class() function) 5/7 Checking commit 9c820045c733 (i386: Remove x86_cpu_set_default_version() function) WARNING: line over 80 characters #81: FILE: target/i386/cpu.c:3178: + (PCMachineClass *)object_class_dynamic_cast(OBJECT_CLASS(mc), TYPE_PC_MACHINE); WARNING: line over 80 characters #87: FILE: target/i386/cpu.c:3184: + return default_cpu_version_for_machine(MACHINE_GET_CLASS(qdev_get_machine())); WARNING: line over 80 characters #110: FILE: target/i386/cpu.c:4134: + X86CPUVersion version = x86_cpu_model_resolve_version(model, default_cpu_version()); total: 0 errors, 3 warnings, 88 lines checked Patch 5/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/7 Checking commit a94469ea9b83 (i386: Don't use default_cpu_version() inside query-cpu-definitions) 7/7 Checking commit 80774f3866be (cpu: Add `machine` parameter to query-cpu-definitions) WARNING: line over 80 characters #147: FILE: tests/acceptance/x86_cpu_model_versions.py:238: + """Check if unversioned CPU model is an alias pointing to right version""" ERROR: line over 90 characters #152: FILE: tests/acceptance/x86_cpu_model_versions.py:243: + cpus1 = dict((m['name'], m.get('alias-of')) for m in vm1.command('query-cpu-definitions', machine='none')) ERROR: line over 90 characters #159: FILE: tests/acceptance/x86_cpu_model_versions.py:250: + cpus2 = dict((m['name'], m.get('alias-of')) for m in vm2.command('query-cpu-definitions')) WARNING: line over 80 characters #165: FILE: tests/acceptance/x86_cpu_model_versions.py:256: + """Check if unversioned CPU model is an alias pointing to right version""" ERROR: line over 90 characters #170: FILE: tests/acceptance/x86_cpu_model_versions.py:261: + cpus1 = dict((m['name'], m.get('alias-of')) for m in vm1.command('query-cpu-definitions', machine='pc-i440fx-4.1')) ERROR: line over 90 characters #177: FILE: tests/acceptance/x86_cpu_model_versions.py:268: + cpus2 = dict((m['name'], m.get('alias-of')) for m in vm2.command('query-cpu-definitions')) total: 4 errors, 2 warnings, 141 lines checked Patch 7/7 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191025022553.25298-1-ehabk...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com