Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-10 Thread Richard Henderson
On 7/10/20 12:03 AM, LIU Zhiwei wrote: > The comment is moving both inputs check and the result nan-boxing code to > helper functions. > > In my opinion, it doesn't matter whether put them into helper functions or > into > translation functions. > More importantly, we should add inputs check and

Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-10 Thread LIU Zhiwei
On 2020/7/8 23:35, Richard Henderson wrote: On 7/7/20 2:45 PM, LIU Zhiwei wrote: On 2020/7/3 1:37, Richard Henderson wrote: I think it would be better to do all of the nan-boxing work inside of the helpers, including the return values. Do you mean a helper function just for nan-boxing work?

Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-08 Thread Richard Henderson
On 7/7/20 2:45 PM, LIU Zhiwei wrote: >> On 2020/7/3 1:37, Richard Henderson wrote: >>> I think it would be better to do all of the nan-boxing work inside of the >>> helpers, including the return values. >> Do you mean a helper function just for nan-boxing work? No, that's not what I mean. >> I do

Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-07 Thread LIU Zhiwei
Hi Richard, Ping for other patches in this patch set. I may not get you ideas. Could you give more information? Zhiwei On 2020/7/3 20:33, LIU Zhiwei wrote: On 2020/7/3 1:37, Richard Henderson wrote: On 6/26/20 1:59 PM, LIU Zhiwei wrote: Multiple precison shoule be supported by NaN-boxing.

Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-07-02 Thread Richard Henderson
On 6/26/20 1:59 PM, LIU Zhiwei wrote: > Multiple precison shoule be supported by NaN-boxing. That means, we should > flush not valid NaN-boxing input to canonical NaN before effective > calculation and we should NaN-boxing the result after the effective > calculation. > > In this patch set, split

Re: [PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-06-26 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200626205917.4545-1-zhiwei_...@c-sky.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN ===

[PATCH 0/6] target/riscv: NaN-boxing for multiple precison

2020-06-26 Thread LIU Zhiwei
Multiple precison shoule be supported by NaN-boxing. That means, we should flush not valid NaN-boxing input to canonical NaN before effective calculation and we should NaN-boxing the result after the effective calculation. In this patch set, split the implementation to three steps for compute, sig