On 7/10/20 12:03 AM, LIU Zhiwei wrote: > The comment is moving both inputs check and the result nan-boxing code to > helper functions. > > In my opinion, it doesn't matter whether put them into helper functions or > into > translation functions. > More importantly, we should add inputs check and result nan-boxing for all > single float point instructions. > > If you insist on we should move it to helper functions, I'd like to.:-)
I don't insist, but I think it makes sense to do so. Less code in translate means less time in the JIT, and more sharing of the icache. Sometimes it's a tradeoff, but in this case because we will always call a helper, I think that the benefits are all positive to move the extra code into the helper. r~
