Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2020-01-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 1/23/20 12:28 PM, Alex Bennée wrote: >> Philippe Mathieu-Daudé writes: >> >>> On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote: Fix some trivial warnings when building with -O3. Philippe Mathieu-Daudé (6): audio/audio: Add missing fall t

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2020-01-23 Thread Philippe Mathieu-Daudé
On 1/23/20 12:28 PM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote: Fix some trivial warnings when building with -O3. Philippe Mathieu-Daudé (6): audio/audio: Add missing fall through comment hw/display/tcx: Add missing fall throug

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2020-01-23 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote: >> Fix some trivial warnings when building with -O3. >> Philippe Mathieu-Daudé (6): >>audio/audio: Add missing fall through comment >>hw/display/tcx: Add missing fall through comments >>hw/net/imx_fe

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2020-01-21 Thread Paolo Bonzini
On 20/01/20 20:02, Philippe Mathieu-Daudé wrote: > Hi Paolo, > > On 1/18/20 8:24 PM, Paolo Bonzini wrote: >> On 18/12/19 07:05, Markus Armbruster wrote: >>> "Chubb, Peter (Data61, Kensington NSW)" >>> writes: >>> > "Philippe" == Philippe Mathieu-Daudé writes: Philippe> Fix some

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2020-01-20 Thread Philippe Mathieu-Daudé
Hi Paolo, On 1/18/20 8:24 PM, Paolo Bonzini wrote: On 18/12/19 07:05, Markus Armbruster wrote: "Chubb, Peter (Data61, Kensington NSW)" writes: "Philippe" == Philippe Mathieu-Daudé writes: Philippe> Fix some trivial warnings when building with -O3. For compatibility with lint and other ol

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2020-01-18 Thread Paolo Bonzini
On 18/12/19 07:05, Markus Armbruster wrote: > "Chubb, Peter (Data61, Kensington NSW)" > writes: > >>> "Philippe" == Philippe Mathieu-Daudé writes: >> >> Philippe> Fix some trivial warnings when building with -O3. >> >> For compatibility with lint and other older checkers, it'd be good to kee

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2019-12-17 Thread Markus Armbruster
"Chubb, Peter (Data61, Kensington NSW)" writes: >> "Philippe" == Philippe Mathieu-Daudé writes: > > Philippe> Fix some trivial warnings when building with -O3. > > For compatibility with lint and other older checkers, it'd be good to keep > this as /* FALLTHROUGH */ (which gcc should accept

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2019-12-17 Thread Chubb, Peter (Data61, Kensington NSW)
> "Philippe" == Philippe Mathieu-Daudé writes: Philippe> Fix some trivial warnings when building with -O3. For compatibility with lint and other older checkers, it'd be good to keep this as /* FALLTHROUGH */ (which gcc should accept according to its manual). Fixing the comments' placement i

Re: [PATCH 0/6] Fix more GCC9 -O3 warnings

2019-12-17 Thread Philippe Mathieu-Daudé
On 12/17/19 6:32 PM, Philippe Mathieu-Daudé wrote: Fix some trivial warnings when building with -O3. Philippe Mathieu-Daudé (6): audio/audio: Add missing fall through comment hw/display/tcx: Add missing fall through comments hw/net/imx_fec: Rewrite fall through comments hw/timer/aspe

[PATCH 0/6] Fix more GCC9 -O3 warnings

2019-12-17 Thread Philippe Mathieu-Daudé
Fix some trivial warnings when building with -O3. Philippe Mathieu-Daudé (6): audio/audio: Add missing fall through comment hw/display/tcx: Add missing fall through comments hw/net/imx_fec: Rewrite fall through comments hw/timer/aspeed_timer: Add a fall through comment hw/scsi/megasas: S

[PATCH 0/6] Fix more GCC9 -O3 warnings

2019-12-17 Thread Philippe Mathieu-Daudé
Fix some trivial warnings when building with -O3. Philippe Mathieu-Daudé (6): audio/audio: Add missing fall through comment hw/display/tcx: Add missing fall through comments hw/net/imx_fec: Rewrite fall through comments hw/timer/aspeed_timer: Add a fall through comment hw/scsi/megasas: S