Hi Paolo,
On 1/18/20 8:24 PM, Paolo Bonzini wrote:
On 18/12/19 07:05, Markus Armbruster wrote:
"Chubb, Peter (Data61, Kensington NSW)" <peter.ch...@data61.csiro.au>
writes:
"Philippe" == Philippe Mathieu-Daudé <phi...@redhat.com> writes:
Philippe> Fix some trivial warnings when building with -O3.
For compatibility with lint and other older checkers, it'd be good to keep
this as /* FALLTHROUGH */ (which gcc should accept according to its
manual).
We have hundreds of /* fall through */ comments already.
Fixing the comments' placement is a different matter, and should be
done. Seems to me that until gcc started warning for this, noone had
actually run a checker, and the comments were just for human info.
Peter C
Queued, thanks.
Thanks, but I sent a v2 (20191218192526.13845-1-phi...@redhat.com) with:
- addressed Thomas and Aleksandar comments
- dropped 'hw/scsi/megasas: Silent GCC9 duplicated-cond warning'
- dropped 'qemu-io-cmds: Silent GCC9 format-overflow warning'
See:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg666280.html
Can you queue it instead?
