On Mon, Feb 24, 2020 at 10:34:04AM +, Stefan Hajnoczi wrote:
> QLIST_REMOVE() and friends leave dangling linked list pointers in the node
> that
> was removed. This makes it impossible to decide whether a node is currently
> in
> a list or not. It also makes debugging harder.
>
> Based-on:
On 2/25/20 10:05 AM, Stefan Hajnoczi wrote:
On Mon, Feb 24, 2020 at 12:54:37PM +0100, Philippe Mathieu-Daudé wrote:
On 2/24/20 12:39 PM, Stefan Hajnoczi wrote:
On Mon, Feb 24, 2020 at 02:55:33AM -0800, no-re...@patchew.org wrote:
=== OUTPUT BEGIN ===
1/2 Checking commit f913b2430ad3 (qemu/queu
On Mon, Feb 24, 2020 at 12:54:37PM +0100, Philippe Mathieu-Daudé wrote:
> On 2/24/20 12:39 PM, Stefan Hajnoczi wrote:
> > On Mon, Feb 24, 2020 at 02:55:33AM -0800, no-re...@patchew.org wrote:
> > > === OUTPUT BEGIN ===
> > > 1/2 Checking commit f913b2430ad3 (qemu/queue.h: clear linked list
> > > p
On 2/24/20 12:39 PM, Stefan Hajnoczi wrote:
On Mon, Feb 24, 2020 at 02:55:33AM -0800, no-re...@patchew.org wrote:
=== OUTPUT BEGIN ===
1/2 Checking commit f913b2430ad3 (qemu/queue.h: clear linked list pointers on
remove)
ERROR: do not use assignment in if condition
#65: FILE: include/qemu/queue
On Mon, Feb 24, 2020 at 02:55:33AM -0800, no-re...@patchew.org wrote:
> === OUTPUT BEGIN ===
> 1/2 Checking commit f913b2430ad3 (qemu/queue.h: clear linked list pointers on
> remove)
> ERROR: do not use assignment in if condition
> #65: FILE: include/qemu/queue.h:314:
> +if (((head)->sqh_first
Patchew URL:
https://patchew.org/QEMU/20200224103406.1894923-1-stefa...@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PATCH 0/2] qemu/queue.h: clear linked list pointers on remove
Message-id: 20200224103406.1894923-1
QLIST_REMOVE() and friends leave dangling linked list pointers in the node that
was removed. This makes it impossible to decide whether a node is currently in
a list or not. It also makes debugging harder.
Based-on: 20200222085030.1760640-1-stefa...@redhat.com
("[PULL 00/31] Block patc
