On Mon, Feb 24, 2020 at 02:55:33AM -0800, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > 1/2 Checking commit f913b2430ad3 (qemu/queue.h: clear linked list pointers on > remove) > ERROR: do not use assignment in if condition > #65: FILE: include/qemu/queue.h:314: > + if (((head)->sqh_first = elm->field.sqe_next) == NULL) \ > > total: 1 errors, 0 warnings, 59 lines checked
The same pattern is used elsewhere in this file. This code comes from BSD and doesn't comply with QEMU's coding style. Stefan
signature.asc
Description: PGP signature