Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-07 Thread Richard Henderson
On 11/6/24 17:26, Peter Maydell wrote: On Wed, 6 Nov 2024 at 17:21, Pierrick Bouvier wrote: I noticed by --enable-debug in configure is a combination of enabling checks (enable-debug-tcg + graph + mutex), and deactivating optimizations. Would it be worth keeping the optimizations and runtime c

Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Thomas Huth
On 06/11/2024 19.04, Daniel P. Berrangé wrote: On Wed, Nov 06, 2024 at 06:09:46PM +0100, Thomas Huth wrote: When building QEMU with "--enable-debug" and running the tests in parallel with "make -j$(nproc) check-functional", many tests are still timing out due to our conservative timeout settings

Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Daniel P . Berrangé
On Wed, Nov 06, 2024 at 06:09:46PM +0100, Thomas Huth wrote: > When building QEMU with "--enable-debug" and running the tests > in parallel with "make -j$(nproc) check-functional", many tests are > still timing out due to our conservative timeout settings. Bump > the timeouts of the problematic tes

Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Pierrick Bouvier
On 11/6/24 09:40, Thomas Huth wrote: On 06/11/2024 18.30, Pierrick Bouvier wrote: On 11/6/24 09:26, Peter Maydell wrote: On Wed, 6 Nov 2024 at 17:21, Pierrick Bouvier wrote: I noticed by --enable-debug in configure is a combination of enabling checks (enable-debug-tcg + graph + mutex), and de

Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Thomas Huth
On 06/11/2024 18.30, Pierrick Bouvier wrote: On 11/6/24 09:26, Peter Maydell wrote: On Wed, 6 Nov 2024 at 17:21, Pierrick Bouvier wrote: I noticed by --enable-debug in configure is a combination of enabling checks (enable-debug-tcg + graph + mutex), and deactivating optimizations. Would it be

Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Pierrick Bouvier
On 11/6/24 09:26, Peter Maydell wrote: On Wed, 6 Nov 2024 at 17:21, Pierrick Bouvier wrote: I noticed by --enable-debug in configure is a combination of enabling checks (enable-debug-tcg + graph + mutex), and deactivating optimizations. Would it be worth keeping the optimizations and runtime c

Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Peter Maydell
On Wed, 6 Nov 2024 at 17:21, Pierrick Bouvier wrote: > I noticed by --enable-debug in configure is a combination of enabling > checks (enable-debug-tcg + graph + mutex), and deactivating optimizations. > > Would it be worth keeping the optimizations and runtime checks instead? > This way, there wo

Re: [PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Pierrick Bouvier
On 11/6/24 09:09, Thomas Huth wrote: When building QEMU with "--enable-debug" and running the tests in parallel with "make -j$(nproc) check-functional", many tests are still timing out due to our conservative timeout settings. Bump the timeouts of the problematic tests and also increase the defau

[PATCH] tests/functional: Bump timeouts of functional tests

2024-11-06 Thread Thomas Huth
When building QEMU with "--enable-debug" and running the tests in parallel with "make -j$(nproc) check-functional", many tests are still timing out due to our conservative timeout settings. Bump the timeouts of the problematic tests and also increase the default timeout to 90 seconds (from 60 secon