Re: [PATCH] target/riscv: Add User CSRs read-only check

2021-08-09 Thread Bin Meng
On Mon, Aug 9, 2021 at 6:37 PM LIU Zhiwei wrote: > > For U-mode CSRs, read-only check is also needed. > > Signed-off-by: LIU Zhiwei > --- > target/riscv/csr.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/target/riscv/csr.c b/target/riscv/csr.c > index 9a4ed18a

[PATCH] target/riscv: Add User CSRs read-only check

2021-08-09 Thread LIU Zhiwei
For U-mode CSRs, read-only check is also needed. Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 9a4ed18ac5..360e4bfa33 100644 --- a/target/riscv/csr.c +++ b/target/riscv/cs

Re: [PATCH] target/riscv: Add User CSRs read-only check

2021-08-09 Thread Bin Meng
On Mon, Aug 9, 2021 at 5:45 PM LIU Zhiwei wrote: > > > On 2021/8/9 下午5:35, Bin Meng wrote: > > On Mon, Aug 9, 2021 at 3:09 PM LIU Zhiwei wrote: > > nits: please write something in the commit message > OK > > > >> Signed-off-by: LIU Zhiwei > >> --- > >> target/riscv/csr.c | 6 +- > >> 1 fi

Re: [PATCH] target/riscv: Add User CSRs read-only check

2021-08-09 Thread LIU Zhiwei
On 2021/8/9 下午5:35, Bin Meng wrote: On Mon, Aug 9, 2021 at 3:09 PM LIU Zhiwei wrote: nits: please write something in the commit message OK Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/riscv/csr.c b/targ

Re: [PATCH] target/riscv: Add User CSRs read-only check

2021-08-09 Thread Bin Meng
On Mon, Aug 9, 2021 at 3:09 PM LIU Zhiwei wrote: > nits: please write something in the commit message > Signed-off-by: LIU Zhiwei > --- > target/riscv/csr.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/target/riscv/csr.c b/target/riscv/csr.c > index 9a4ed18ac5.

[PATCH] target/riscv: Add User CSRs read-only check

2021-08-09 Thread LIU Zhiwei
Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 9a4ed18ac5..ea62d9e653 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -1422,11 +1422,11 @@ RISCVException riscv_csrr