Re: [PATCH] target/i386: fix operand order for PDEP and PEXT

2020-11-24 Thread Paolo Bonzini
On 24/11/20 18:54, Richard Henderson wrote: +test-i386-bmi2: CFLAGS += -mbmi2 +run-test-i386-bmi2: QEMU_OPTS += -cpu max +run-plugin-test-i386-bmi2-%: QEMU_OPTS += -cpu max I suspect that we still support host operating systems whose compilers do not support -mbmi2. This might require a bit in

Re: [PATCH] target/i386: fix operand order for PDEP and PEXT

2020-11-24 Thread Richard Henderson
On 11/23/20 5:14 AM, Paolo Bonzini wrote: > For PDEP and PEXT, the mask is provided in the memory (mod+r/m) > operand, and therefore is loaded in s->T0 by gen_ldst_modrm. > The source is provided in the second source operand (VEX.) > and therefore is loaded in s->T1. Fix the order in which > t

Re: [PATCH] target/i386: fix operand order for PDEP and PEXT

2020-11-23 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20201123131426.2725276-1-pbonz...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201123131426.2725276-1-pbonz...@redhat.com Subject: [PATCH] target/i386: fix operand

[PATCH] target/i386: fix operand order for PDEP and PEXT

2020-11-23 Thread Paolo Bonzini
For PDEP and PEXT, the mask is provided in the memory (mod+r/m) operand, and therefore is loaded in s->T0 by gen_ldst_modrm. The source is provided in the second source operand (VEX.) and therefore is loaded in s->T1. Fix the order in which they are passed to the helpers. Reported-by: Lenard