Patchew URL: https://patchew.org/QEMU/20201123131426.2725276-1-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20201123131426.2725276-1-pbonz...@redhat.com Subject: [PATCH] target/i386: fix operand order for PDEP and PEXT === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu 8cc30eb..6ab64cc master -> master * [new tag] patchew/20201123131426.2725276-1-pbonz...@redhat.com -> patchew/20201123131426.2725276-1-pbonz...@redhat.com Switched to a new branch 'test' ee94689 target/i386: fix operand order for PDEP and PEXT === OUTPUT BEGIN === WARNING: Block comments use a leading /* on a separate line #28: FILE: target/i386/translate.c:3939: + /* Note that by zero-extending the source operand, we WARNING: Block comments use a leading /* on a separate line #45: FILE: target/i386/translate.c:3957: + /* Note that by zero-extending the source operand, we WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #73: new file mode 100644 ERROR: open brace '{' following function declarations go on the next line #82: FILE: tests/tcg/i386/test-i386-bmi2.c:5: +int main(int argc, char *argv[]) { WARNING: line over 80 characters #93: FILE: tests/tcg/i386/test-i386-bmi2.c:16: + asm volatile ("pdepq %2, %1, %0" : "=r"(result64) : "r"(result64), "m"(mask)); WARNING: line over 80 characters #96: FILE: tests/tcg/i386/test-i386-bmi2.c:19: + asm volatile ("pextq %2, %1, %0" : "=r"(result64) : "r"(-1ull), "m"(mask)); WARNING: line over 80 characters #99: FILE: tests/tcg/i386/test-i386-bmi2.c:22: + asm volatile ("pdepq %2, %1, %0" : "=r"(result64) : "r"(-1ull), "m"(mask)); WARNING: line over 80 characters #103: FILE: tests/tcg/i386/test-i386-bmi2.c:26: + asm volatile ("pextl %2, %k1, %k0" : "=r"(result32) : "r"(ehlo), "m"(mask)); WARNING: line over 80 characters #106: FILE: tests/tcg/i386/test-i386-bmi2.c:29: + asm volatile ("pdepl %2, %k1, %k0" : "=r"(result32) : "r"(result32), "m"(mask)); WARNING: line over 80 characters #109: FILE: tests/tcg/i386/test-i386-bmi2.c:32: + asm volatile ("pextl %2, %k1, %k0" : "=r"(result32) : "r"(-1ull), "m"(mask)); WARNING: line over 80 characters #112: FILE: tests/tcg/i386/test-i386-bmi2.c:35: + asm volatile ("pdepl %2, %k1, %k0" : "=r"(result32) : "r"(-1ull), "m"(mask)); total: 1 errors, 10 warnings, 82 lines checked Commit ee94689b216b (target/i386: fix operand order for PDEP and PEXT) has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20201123131426.2725276-1-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
