Re: [PATCH] softmmu: Move dirtylimit.c into the target independent source set

2023-04-26 Thread Thomas Huth
On 13/04/2023 12.31, Richard Henderson wrote: On 4/13/23 07:45, Thomas Huth wrote:   uint32_t dirty_ring_size = kvm_dirty_ring_size();   uint64_t dirty_ring_size_meory_MB = -    dirty_ring_size * TARGET_PAGE_SIZE >> 20; +    dirty_ring_size * qemu_target_page_size() >> 20; Exis

Re: [PATCH] softmmu: Move dirtylimit.c into the target independent source set

2023-04-13 Thread Richard Henderson
On 4/13/23 07:45, Thomas Huth wrote: uint32_t dirty_ring_size = kvm_dirty_ring_size(); uint64_t dirty_ring_size_meory_MB = -dirty_ring_size * TARGET_PAGE_SIZE >> 20; +dirty_ring_size * qemu_target_page_size() >> 20; Existing problem, the types here are suspicious: di

Re: [PATCH] softmmu: Move dirtylimit.c into the target independent source set

2023-04-13 Thread Fabiano Rosas
Thomas Huth writes: > dirtylimit.c just uses one TARGET_PAGE_SIZE macro - change it to > qemu_target_page_size() so we can move thefile into the target > independent source set. Then we only have to compile this file > once during the build instead of multiple times (one time for > each target).

[PATCH] softmmu: Move dirtylimit.c into the target independent source set

2023-04-12 Thread Thomas Huth
dirtylimit.c just uses one TARGET_PAGE_SIZE macro - change it to qemu_target_page_size() so we can move thefile into the target independent source set. Then we only have to compile this file once during the build instead of multiple times (one time for each target). Signed-off-by: Thomas Huth ---