Re: [PATCH] softmmu: Move dirtylimit.c into the target independent source set

[Richard Henderson]

On 4/13/23 07:45, Thomas Huth wrote:
      uint32_t dirty_ring_size = kvm_dirty_ring_size();
      uint64_t dirty_ring_size_meory_MB =
-        dirty_ring_size * TARGET_PAGE_SIZE >> 20;
+        dirty_ring_size * qemu_target_page_size() >> 20;

Existing problem, the types here are suspicious: dirty_ring_size is uint32_t, 
dirty_ring_size_meory (typo) is uint64_t.

I wonder if this is better computed as

    uint32_t dirty_ring_size_MB = dirty_ring_size >> (20 - 
qemu_target_page_bits());


r~