Re: [PATCH] qcow2: Explicit mention of padding bytes

2023-06-01 Thread Eric Blake
On Mon, May 22, 2023 at 11:26:03PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 22.05.23 21:46, Eric Blake wrote: > > Although we already covered the need for padding bytes with our > > changes in commit 3ae3fcfa, commit 66fcbca5 (both v5.0.0) added one > > byte and relied on the rest of the tex

Re: [PATCH] qcow2: Explicit mention of padding bytes

2023-05-22 Thread Vladimir Sementsov-Ogievskiy
On 22.05.23 21:46, Eric Blake wrote: Although we already covered the need for padding bytes with our changes in commit 3ae3fcfa, commit 66fcbca5 (both v5.0.0) added one byte and relied on the rest of the text for implicitly covering 7 padding bytes. For consistency with other parts of the header

[PATCH] qcow2: Explicit mention of padding bytes

2023-05-22 Thread Eric Blake
Although we already covered the need for padding bytes with our changes in commit 3ae3fcfa, commit 66fcbca5 (both v5.0.0) added one byte and relied on the rest of the text for implicitly covering 7 padding bytes. For consistency with other parts of the header (such as the header extension format l

Re: [PATCH] qcow2: Explicit mention of padding bytes

2020-02-27 Thread Vladimir Sementsov-Ogievskiy
27.02.2020 17:45, Eric Blake wrote: Although we already covered the need for padding bytes with our changes in commit 3ae3fcfa, commit 66fcbca5 just added one byte and relied on the earlier text for implicitly covering 7 padding bytes. For consistency with other parts of the header, it does not h

Re: [PATCH] qcow2: Explicit mention of padding bytes

2020-02-27 Thread Max Reitz
On 27.02.20 15:45, Eric Blake wrote: > Although we already covered the need for padding bytes with our > changes in commit 3ae3fcfa, commit 66fcbca5 just added one byte and > relied on the earlier text for implicitly covering 7 padding bytes. > For consistency with other parts of the header, Those

[PATCH] qcow2: Explicit mention of padding bytes

2020-02-27 Thread Eric Blake
Although we already covered the need for padding bytes with our changes in commit 3ae3fcfa, commit 66fcbca5 just added one byte and relied on the earlier text for implicitly covering 7 padding bytes. For consistency with other parts of the header, it does not hurt to be explicit that this version o