On Mon, May 22, 2023 at 11:26:03PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 22.05.23 21:46, Eric Blake wrote: > > Although we already covered the need for padding bytes with our > > changes in commit 3ae3fcfa, commit 66fcbca5 (both v5.0.0) added one > > byte and relied on the rest of the text for implicitly covering 7 > > padding bytes. For consistency with other parts of the header (such > > as the header extension format listing padding from n - m, or the > > snapshot table entry listing variable padding), we might as well call > > out the remaining 7 bytes as padding until such time (as any) as they > > gain another meaning. > > > > Signed-off-by: Eric Blake <ebl...@redhat.com> > > CC: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru> > > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@yandex-team.ru>
Not strictly related to NBD, but I'll pick it up since I'm about to do a pull request. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
