Re: [PATCH] linux-user: Clean up arg_start/arg_end confusion

2022-03-20 Thread Richard Henderson
On 3/18/22 04:41, Peter Maydell wrote: On Tue, 15 Mar 2022 at 22:47, Richard Henderson wrote: We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the b

Re: [PATCH] linux-user: Clean up arg_start/arg_end confusion

2022-03-18 Thread Peter Maydell
On Tue, 15 Mar 2022 at 22:47, Richard Henderson wrote: > > We had two sets of variables: arg_start/arg_end, and > arg_strings/env_strings. In linuxload.c, we set the > first pair to the bounds of the argv strings, but in > elfload.c, we set the first pair to the bounds of the > argv pointers and

[PATCH] linux-user: Clean up arg_start/arg_end confusion

2022-03-15 Thread Richard Henderson
We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the bounds of the argv pointers and the second pair to the bounds of the argv strings. Remove arg_start