On 3/18/22 04:41, Peter Maydell wrote:
On Tue, 15 Mar 2022 at 22:47, Richard Henderson
<richard.hender...@linaro.org> wrote:
We had two sets of variables: arg_start/arg_end, and
arg_strings/env_strings. In linuxload.c, we set the
first pair to the bounds of the argv strings, but in
elfload.c, we set the first pair to the bounds of the
argv pointers and the second pair to the bounds of
the argv strings.
Remove arg_start/arg_end, replacing them with the standard
argc/argv/envc/envp values. Retain arg_strings/env_strings.
"Retain arg_strings/env_strings with the meaning we were using
in elfload.c" ? (ie linuxload.c changes to that definition).
Ah, yes, quite.
- /* FIXME - handle put_user() failures */
Why are you deleting all these FIXME comments? That seems like an
unrelated change.
Indeed. Instead of just removing these, I should convert to lock the entire buffer and
use __put_user instead.
r~
