Re: [PATCH] hw/rtc/twl92230: Silence warnings about missing fallthrough statements

2020-10-12 Thread Laurent Vivier
Le 01/10/2020 à 20:21, Thomas Huth a écrit : > When compiling with -Werror=implicit-fallthrough, gcc complains about > missing fallthrough annotations in this file. Looking at the code, > the fallthrough is indeed wanted here, but instead of adding the > annotations, it can be done more efficiently

Re: [PATCH] hw/rtc/twl92230: Silence warnings about missing fallthrough statements

2020-10-01 Thread Peter Maydell
On Thu, 1 Oct 2020 at 19:21, Thomas Huth wrote: > > When compiling with -Werror=implicit-fallthrough, gcc complains about > missing fallthrough annotations in this file. Looking at the code, > the fallthrough is indeed wanted here, but instead of adding the > annotations, it can be done more effic

[PATCH] hw/rtc/twl92230: Silence warnings about missing fallthrough statements

2020-10-01 Thread Thomas Huth
When compiling with -Werror=implicit-fallthrough, gcc complains about missing fallthrough annotations in this file. Looking at the code, the fallthrough is indeed wanted here, but instead of adding the annotations, it can be done more efficiently by simply calculating the offset with a subtraction