Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-05 Thread Peter Maydell
On Tue, 5 Nov 2019 at 11:20, Richard Henderson wrote: > > On 11/1/19 11:42 AM, Peter Maydell wrote: > > The other place that might need checking is the PSCI/etc > > code for doing CPU power on/off (and other callers to the > > power up/down functions like the imx6 power control regs). > > Richard,

Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-05 Thread Richard Henderson
On 11/1/19 11:42 AM, Peter Maydell wrote: > The other place that might need checking is the PSCI/etc > code for doing CPU power on/off (and other callers to the > power up/down functions like the imx6 power control regs). > Richard, did you look at that code to see if it needed hflags updates? I h

Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191101103232.3692818-1-luc.mic...@greensocs.com/ Hi, This series failed the docker-mingw@fedora build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BE

Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-01 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20191101103232.3692818-1-luc.mic...@greensocs.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT B

Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-01 Thread Luc Michel
On 11/1/19 11:42 AM, Peter Maydell wrote: > On Fri, 1 Nov 2019 at 10:32, Luc Michel wrote: >> >> This machine modifies the CPU state when simulating suspend mode. This >> commit adds a missing call to arm_rebuild_hflags after those >> modifications. >> >> Signed-off-by: Luc Michel >> --- >> I cam

Re: [PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-01 Thread Peter Maydell
On Fri, 1 Nov 2019 at 10:32, Luc Michel wrote: > > This machine modifies the CPU state when simulating suspend mode. This > commit adds a missing call to arm_rebuild_hflags after those > modifications. > > Signed-off-by: Luc Michel > --- > I came over this missing hflags rebuild while reviewing E

[PATCH] hw/arm/pxa2xx: rebuild hflags cache when modifying CPU state

2019-11-01 Thread Luc Michel
This machine modifies the CPU state when simulating suspend mode. This commit adds a missing call to arm_rebuild_hflags after those modifications. Signed-off-by: Luc Michel --- I came over this missing hflags rebuild while reviewing Edgar's similar fix in hw/arm/boot.c. I could not find any other