On Fri, 1 Nov 2019 at 10:32, Luc Michel <luc.mic...@greensocs.com> wrote: > > This machine modifies the CPU state when simulating suspend mode. This > commit adds a missing call to arm_rebuild_hflags after those > modifications. > > Signed-off-by: Luc Michel <luc.mic...@greensocs.com> > --- > I came over this missing hflags rebuild while reviewing Edgar's similar > fix in hw/arm/boot.c. I could not find any other place where it would be > missing but I may be wrong.
pxa2xx_pwrmode_write() is a cp14 coprocessor register write function, so I think that the hflags rebuild that is done by translate.c:disas_coproc_insn() after a cp register write should already handle this case ? The other place that might need checking is the PSCI/etc code for doing CPU power on/off (and other callers to the power up/down functions like the imx6 power control regs). Richard, did you look at that code to see if it needed hflags updates? thanks -- PMM
