Re: [PATCH] cpus: kick all vCPUs when running thread=single

2019-10-07 Thread Alex Bennée
Richard Henderson writes: > On 10/6/19 9:05 AM, Paolo Bonzini wrote: >> On 01/10/19 19:40, Alex Bennée wrote: >>> >>> Paolo Bonzini writes: >>> On 01/10/19 18:04, Alex Bennée wrote: > qemu_cpu_kick is used for a number of reasons including to indicate > there is work to be done. H

Re: [PATCH] cpus: kick all vCPUs when running thread=single

2019-10-07 Thread Paolo Bonzini
On 07/10/19 16:00, Richard Henderson wrote: >> I wasn't, since we have had a proper TCG maintainer for a while. :) > Hah. Point taken, and queued. Would you care to go on the record with > something more than a LGTM? Sure, Reviewed-by: Paolo Bonzini

Re: [PATCH] cpus: kick all vCPUs when running thread=single

2019-10-07 Thread Richard Henderson
On 10/6/19 9:05 AM, Paolo Bonzini wrote: > On 01/10/19 19:40, Alex Bennée wrote: >> >> Paolo Bonzini writes: >> >>> On 01/10/19 18:04, Alex Bennée wrote: qemu_cpu_kick is used for a number of reasons including to indicate there is work to be done. However when thread=single the old

Re: [PATCH] cpus: kick all vCPUs when running thread=single

2019-10-06 Thread Paolo Bonzini
On 01/10/19 19:40, Alex Bennée wrote: > > Paolo Bonzini writes: > >> On 01/10/19 18:04, Alex Bennée wrote: >>> qemu_cpu_kick is used for a number of reasons including to indicate >>> there is work to be done. However when thread=single the old >>> qemu_cpu_kick_rr_cpu only advanced the vCPU to t

Re: [PATCH] cpus: kick all vCPUs when running thread=single

2019-10-01 Thread Alex Bennée
Paolo Bonzini writes: > On 01/10/19 18:04, Alex Bennée wrote: >> qemu_cpu_kick is used for a number of reasons including to indicate >> there is work to be done. However when thread=single the old >> qemu_cpu_kick_rr_cpu only advanced the vCPU to the next executing one >> which can lead to a ha

Re: [PATCH] cpus: kick all vCPUs when running thread=single

2019-10-01 Thread Paolo Bonzini
On 01/10/19 18:04, Alex Bennée wrote: > qemu_cpu_kick is used for a number of reasons including to indicate > there is work to be done. However when thread=single the old > qemu_cpu_kick_rr_cpu only advanced the vCPU to the next executing one > which can lead to a hang in the case that: > > a) t

[PATCH] cpus: kick all vCPUs when running thread=single

2019-10-01 Thread Alex Bennée
qemu_cpu_kick is used for a number of reasons including to indicate there is work to be done. However when thread=single the old qemu_cpu_kick_rr_cpu only advanced the vCPU to the next executing one which can lead to a hang in the case that: a) the kick is from outside the vCPUs (e.g. iothread)