Re: [PATCH] build: remove redundant 'check-build' make target

2021-08-11 Thread Daniel P . Berrangé
On Wed, Aug 11, 2021 at 08:02:44AM +0200, Thomas Huth wrote: > On 10/08/2021 18.44, Daniel P. Berrangé wrote: > > The 'check-build' make target was added as a way to build all the unit > > test binaries, since the standard 'all' target would not trigger this. > > > > Since the switch to meson, how

Re: [PATCH] build: remove redundant 'check-build' make target

2021-08-10 Thread Thomas Huth
On 10/08/2021 18.44, Daniel P. Berrangé wrote: The 'check-build' make target was added as a way to build all the unit test binaries, since the standard 'all' target would not trigger this. Since the switch to meson, however, 'all' will now include the 'test' binaries. As a result, 'check-build'

Re: [PATCH] build: remove redundant 'check-build' make target

2021-08-10 Thread Willian Rampazzo
On Tue, Aug 10, 2021 at 1:44 PM Daniel P. Berrangé wrote: > > The 'check-build' make target was added as a way to build all the unit > test binaries, since the standard 'all' target would not trigger this. > > Since the switch to meson, however, 'all' will now include the 'test' > binaries. As a r

[PATCH] build: remove redundant 'check-build' make target

2021-08-10 Thread Daniel P . Berrangé
The 'check-build' make target was added as a way to build all the unit test binaries, since the standard 'all' target would not trigger this. Since the switch to meson, however, 'all' will now include the 'test' binaries. As a result, 'check-build' is a no-op: $ make all check-build ..snip