On Wed, Aug 11, 2021 at 08:02:44AM +0200, Thomas Huth wrote: > On 10/08/2021 18.44, Daniel P. Berrangé wrote: > > The 'check-build' make target was added as a way to build all the unit > > test binaries, since the standard 'all' target would not trigger this. > > > > Since the switch to meson, however, 'all' will now include the 'test' > > binaries. As a result, 'check-build' is a no-op: > > > > $ make all check-build > > ..snip lots of output... > > make: Nothing to be done for 'check-build'. > > I think it would be better to restore the previous behaviour, so that "all" > does not build the test files by default. Most normal users don't need the > tests, so compiling them by default wastes precious CPU cycles.
Building tests by default is a good idea. If I'm refactoring code I want to see straight away if I've broken test binaries, just as much as if I've broken a part of the emulator code. I wouldn't want QEMU to go back to the old behaviour as IMHO that is broken. If someone doesn't want to run tests in a particular scenario, then by all means have a meson option to disable tests entirely - neither build nor run them - which wouldn't require a target to trigger test builds manually. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
