Re: [PATCH] bios-tables-test: do not ignore allowed diff list

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 01:31:04PM +0100, Igor Mammedov wrote: > On Mon, 31 Oct 2022 06:52:11 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Oct 31, 2022 at 11:49:42AM +0100, Igor Mammedov wrote: > > > On Thu, 27 Oct 2022 11:11:48 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > we ha

Re: [PATCH] bios-tables-test: do not ignore allowed diff list

2022-10-31 Thread Igor Mammedov
On Mon, 31 Oct 2022 06:52:11 -0400 "Michael S. Tsirkin" wrote: > On Mon, Oct 31, 2022 at 11:49:42AM +0100, Igor Mammedov wrote: > > On Thu, 27 Oct 2022 11:11:48 -0400 > > "Michael S. Tsirkin" wrote: > > > > > we had such a beautiful structure for updating > > > expected files, designed to kee

Re: [PATCH] bios-tables-test: do not ignore allowed diff list

2022-10-31 Thread Ani Sinha
On Mon, Oct 31, 2022 at 18:01 Igor Mammedov wrote: > On Mon, 31 Oct 2022 06:52:11 -0400 > "Michael S. Tsirkin" wrote: > > > On Mon, Oct 31, 2022 at 11:49:42AM +0100, Igor Mammedov wrote: > > > On Thu, 27 Oct 2022 11:11:48 -0400 > > > "Michael S. Tsirkin" wrote: > > > > > > > we had such a beaut

Re: [PATCH] bios-tables-test: do not ignore allowed diff list

2022-10-31 Thread Michael S. Tsirkin
On Mon, Oct 31, 2022 at 11:49:42AM +0100, Igor Mammedov wrote: > On Thu, 27 Oct 2022 11:11:48 -0400 > "Michael S. Tsirkin" wrote: > > > we had such a beautiful structure for updating > > expected files, designed to keep bisect working. > > It turns out that we ignored the result of > > the allow

Re: [PATCH] bios-tables-test: do not ignore allowed diff list

2022-10-31 Thread Igor Mammedov
On Thu, 27 Oct 2022 11:11:48 -0400 "Michael S. Tsirkin" wrote: > we had such a beautiful structure for updating > expected files, designed to keep bisect working. > It turns out that we ignored the result of > the allow list checks unless all tables matched > anyway. > > Sigh. strange, it seems

Re: [PATCH] bios-tables-test: do not ignore allowed diff list

2022-10-27 Thread Ani Sinha
On Thu, Oct 27, 2022 at 8:41 PM Michael S. Tsirkin wrote: > > we had such a beautiful structure for updating > expected files, designed to keep bisect working. > It turns out that we ignored the result of > the allow list checks unless all tables matched > anyway. Doh! Seems the bug is present f

[PATCH] bios-tables-test: do not ignore allowed diff list

2022-10-27 Thread Michael S. Tsirkin
we had such a beautiful structure for updating expected files, designed to keep bisect working. It turns out that we ignored the result of the allow list checks unless all tables matched anyway. Sigh. Let's at least make it work going forward. Signed-off-by: Michael S. Tsirkin --- tests/qtest/