On Thu, 27 Oct 2022 11:11:48 -0400 "Michael S. Tsirkin" <m...@redhat.com> wrote:
> we had such a beautiful structure for updating > expected files, designed to keep bisect working. > It turns out that we ignored the result of > the allow list checks unless all tables matched > anyway. > > Sigh. strange, it seems to be working fine (I mean white-listing) here > > Let's at least make it work going forward. > > Signed-off-by: Michael S. Tsirkin <m...@redhat.com> > --- > tests/qtest/bios-tables-test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c > index e6096e7f73..a72f6ca326 100644 > --- a/tests/qtest/bios-tables-test.c > +++ b/tests/qtest/bios-tables-test.c > @@ -458,7 +458,7 @@ static void test_acpi_asl(test_data *data) > "for instructions on how to update expected files.\n", > exp_sdt->aml, sdt->aml_file, exp_sdt->aml_file); > > - all_tables_match = all_tables_match && > + all_tables_match = all_tables_match || > test_acpi_find_diff_allowed(exp_sdt); > > /*