Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields

2021-02-16 Thread Igor Mammedov
On Mon, 15 Feb 2021 20:26:10 +0200 Marian Postevca wrote: > Igor Mammedov writes: > > > hmm, looks like adding instead of removing > > > Do you mean that the commit message does not describe the change > correctly, or that my refactoring is too extreme? I've meant that diff-stat shows that pa

Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields

2021-02-15 Thread Marian Postevca
Igor Mammedov writes: > hmm, looks like adding instead of removing > Do you mean that the commit message does not describe the change correctly, or that my refactoring is too extreme? If it is the latter, I think I tried to simplify things, by creating macros to be used in multiple places where

Re: [PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields

2021-02-15 Thread Igor Mammedov
On Sat, 13 Feb 2021 12:22:33 +0200 Marian Postevca wrote: > The code handling OEM ID and OEM table ID fields had some duplicated > code and was using unnecessary dynamically allocated memory. > This change fixes that. > > Signed-off-by: Marian Postevca [...] > 24 files changed, 190 insertions(

[PATCH] acpi: Remove duplicated code handling OEM ID and OEM table ID fields

2021-02-13 Thread Marian Postevca
The code handling OEM ID and OEM table ID fields had some duplicated code and was using unnecessary dynamically allocated memory. This change fixes that. Signed-off-by: Marian Postevca --- hw/acpi/hmat.h | 2 +- hw/i386/acpi-common.h| 2 +- include/hw/acpi/acpi-bu