On Mon, 15 Feb 2021 20:26:10 +0200 Marian Postevca <poste...@mutex.one> wrote:
> Igor Mammedov <imamm...@redhat.com> writes: > > > hmm, looks like adding instead of removing > > > Do you mean that the commit message does not describe the change > correctly, or that my refactoring is too extreme? I've meant that diff-stat shows that patch adds more lines than it removes so I'm not sure it removes duplication. Maybe rephrase commit message a little. > If it is the latter, I think I tried to simplify things, by creating > macros to be used in multiple places where this structure is created. > And passing the structure around instead of two parameters seemed simpler. > > > have you considered, putting this field into X86MachineState? > > (that way you will be able to handle both PC and microvm in one place, > > without duplication io init/property setters) > > > I did not, will try this approach. this would be pure deduplication, and simpler if you do it as separate patch and then re-factoring to static fields on top of that. (i.e. don't mix re-factoring and deduplication)
