Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-16 Thread Igor Mammedov
On Fri, 13 Mar 2020 11:26:45 -0400 "Michael S. Tsirkin" wrote: > On Fri, Mar 13, 2020 at 10:36:56AM +0100, Igor Mammedov wrote: > > On Thu, 12 Mar 2020 13:09:51 -0400 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > > > > On Wed, 11

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Michael S. Tsirkin
On Fri, Mar 13, 2020 at 10:36:56AM +0100, Igor Mammedov wrote: > On Thu, 12 Mar 2020 13:09:51 -0400 > "Michael S. Tsirkin" wrote: > > > On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > > > On Wed, 11 Mar 2020 19:08:26 +0200 > > > Liran Alon wrote: > > > > > > > From: Elad Gaba

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Liran Alon
On 13/03/2020 12:05, Igor Mammedov wrote: On Thu, 12 Mar 2020 19:28:31 +0200 Liran Alon wrote: On 12/03/2020 18:27, Igor Mammedov wrote: On Wed, 11 Mar 2020 19:08:26 +0200 Liran Alon wrote: + [...] we typically do not version ACPI table changes (there might be exceptions but it should b

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Igor Mammedov
On Thu, 12 Mar 2020 19:28:31 +0200 Liran Alon wrote: > On 12/03/2020 18:27, Igor Mammedov wrote: > > On Wed, 11 Mar 2020 19:08:26 +0200 > > Liran Alon wrote: > >> + [...] > > we typically do not version ACPI table changes (there might be exceptions > > but it should be a justified one). > > AC

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Igor Mammedov
On Thu, 12 Mar 2020 13:09:51 -0400 "Michael S. Tsirkin" wrote: > On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > > On Wed, 11 Mar 2020 19:08:26 +0200 > > Liran Alon wrote: > > > > > From: Elad Gabay > > > > > > Microsoft introduced this ACPI table to avoid Windows guests pe

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-13 Thread Igor Mammedov
On Thu, 12 Mar 2020 20:48:48 +0200 Liran Alon wrote: > On 12/03/2020 18:35, Igor Mammedov wrote: > > On Thu, 12 Mar 2020 14:55:50 +0200 > > Liran Alon wrote: > > > >> On 12/03/2020 14:19, Michael S. Tsirkin wrote: > >>> On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote: > On

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Liran Alon
On 12/03/2020 21:47, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 07:28:31PM +0200, Liran Alon wrote: On 12/03/2020 18:27, Igor Mammedov wrote: On Wed, 11 Mar 2020 19:08:26 +0200 Liran Alon wrote: we typically do not version ACPI table changes (there might be exceptions but it should b

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 07:28:31PM +0200, Liran Alon wrote: > > On 12/03/2020 18:27, Igor Mammedov wrote: > > On Wed, 11 Mar 2020 19:08:26 +0200 > > Liran Alon wrote: > > > + > > > +static void > > > +build_waet(GArray *table_data, BIOSLinker *linker) > > see build_hmat_lb() for example how to do

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Liran Alon
On 12/03/2020 18:35, Igor Mammedov wrote: On Thu, 12 Mar 2020 14:55:50 +0200 Liran Alon wrote: On 12/03/2020 14:19, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote: On 12/03/2020 8:12, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 01:20:02AM +0200,

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Liran Alon
On 12/03/2020 18:27, Igor Mammedov wrote: On Wed, 11 Mar 2020 19:08:26 +0200 Liran Alon wrote: + +static void +build_waet(GArray *table_data, BIOSLinker *linker) see build_hmat_lb() for example how to doc comment for such function should look like. Use earliest spec version where table was i

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 05:27:45PM +0100, Igor Mammedov wrote: > On Wed, 11 Mar 2020 19:08:26 +0200 > Liran Alon wrote: > > > From: Elad Gabay > > > > Microsoft introduced this ACPI table to avoid Windows guests performing > > various workarounds for device erratas. As the virtual device emulat

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Igor Mammedov
On Thu, 12 Mar 2020 14:55:50 +0200 Liran Alon wrote: > On 12/03/2020 14:19, Michael S. Tsirkin wrote: > > On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote: > >> On 12/03/2020 8:12, Michael S. Tsirkin wrote: > >>> On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote: > O

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Igor Mammedov
On Wed, 11 Mar 2020 19:08:26 +0200 Liran Alon wrote: > From: Elad Gabay > > Microsoft introduced this ACPI table to avoid Windows guests performing > various workarounds for device erratas. As the virtual device emulated > by VMM may not have the errata. > > Currently, WAET allows hypervisor t

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Liran Alon
On 12/03/2020 14:19, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote: On 12/03/2020 8:12, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote: On 11/03/2020 22:36, Michael S. Tsirkin wrote: Thanks for the patch! Some ques

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 01:30:01PM +0200, Liran Alon wrote: > > On 12/03/2020 8:12, Michael S. Tsirkin wrote: > > On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote: > > > On 11/03/2020 22:36, Michael S. Tsirkin wrote: > > > > Thanks for the patch! Some questions/comments: > > > > > > > >

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-12 Thread Liran Alon
On 12/03/2020 8:12, Michael S. Tsirkin wrote: On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote: On 11/03/2020 22:36, Michael S. Tsirkin wrote: Thanks for the patch! Some questions/comments: On Wed, Mar 11, 2020 at 07:08:26PM +0200, Liran Alon wrote: From: Elad Gabay Microsoft in

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 03:31:49AM +0200, Liran Alon wrote: > > On 11/03/2020 22:24, Michael S. Tsirkin wrote: > > Notice the process as documented in ./tests/qtest/bios-tables-test.c > > > Thanks for explicitly pointing me to that process. > > I have followed the process described there (Both s

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Michael S. Tsirkin
On Thu, Mar 12, 2020 at 01:20:02AM +0200, Liran Alon wrote: > > On 11/03/2020 22:36, Michael S. Tsirkin wrote: > > Thanks for the patch! Some questions/comments: > > > > On Wed, Mar 11, 2020 at 07:08:26PM +0200, Liran Alon wrote: > > > From: Elad Gabay > > > > > > Microsoft introduced this ACPI

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Liran Alon
On 11/03/2020 22:24, Michael S. Tsirkin wrote: Notice the process as documented in ./tests/qtest/bios-tables-test.c Thanks for explicitly pointing me to that process. I have followed the process described there (Both steps 1-3 and steps 4-7). On step (6), I have noted that many existing ACP

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Liran Alon
On 11/03/2020 22:36, Michael S. Tsirkin wrote: Thanks for the patch! Some questions/comments: On Wed, Mar 11, 2020 at 07:08:26PM +0200, Liran Alon wrote: From: Elad Gabay Microsoft introduced this ACPI table to avoid Windows guests performing various workarounds for device erratas. As the v

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Michael S. Tsirkin
Thanks for the patch! Some questions/comments: On Wed, Mar 11, 2020 at 07:08:26PM +0200, Liran Alon wrote: > From: Elad Gabay > > Microsoft introduced this ACPI table to avoid Windows guests performing > various workarounds for device erratas. As the virtual device emulated > by VMM may not have

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2020 at 09:08:56PM +0200, Liran Alon wrote: > > On 11/03/2020 20:59, no-re...@patchew.org wrote: > > Patchew URL: > > https://urldefense.com/v3/__https://patchew.org/QEMU/20200311170826.79419-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!L4XXKjkDknE86ihbnytm45vsQI41J-QWVCZRoXEXtPKIAsM

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Liran Alon
On 11/03/2020 20:59, no-re...@patchew.org wrote: Patchew URL: https://urldefense.com/v3/__https://patchew.org/QEMU/20200311170826.79419-1-liran.a...@oracle.com/__;!!GqivPVa7Brio!L4XXKjkDknE86ihbnytm45vsQI41J-QWVCZRoXEXtPKIAsMmknrGJWVPZpKgLyM$ Hi, This series failed the docker-quick@centos7 b

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200311170826.79419-1-liran.a...@oracle.com/ Hi, This series failed the asan build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN === #!/bin/bash e

Re: [PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20200311170826.79419-1-liran.a...@oracle.com/ Hi, This series failed the docker-quick@centos7 build test. Please find the testing commands and their output below. If you have Docker installed, you can probably reproduce it locally. === TEST SCRIPT BEGIN

[PATCH] acpi: Add Windows ACPI Emulated Device Table (WAET)

2020-03-11 Thread Liran Alon
From: Elad Gabay Microsoft introduced this ACPI table to avoid Windows guests performing various workarounds for device erratas. As the virtual device emulated by VMM may not have the errata. Currently, WAET allows hypervisor to inform guest about two specific behaviors: One for RTC and the othe