On 12/03/2020 21:47, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2020 at 07:28:31PM +0200, Liran Alon wrote:
On 12/03/2020 18:27, Igor Mammedov wrote:
On Wed, 11 Mar 2020 19:08:26 +0200
Liran Alon <liran.a...@oracle.com> wrote:
we typically do not version ACPI table changes (there might be exceptions
but it should be a justified one).
ACPI tables are considered to be a part of firmware (even though they are
generated by QEMU) so on QEMU upgrade user gets a new firmware along with
new ACPI tables.
Hmm... I would have expected as a QEMU user that upgrading QEMU may update
my firmware exposed table (Such as ACPI),
but only if I don't specify I wish to run on a specific machine-type. In
that case, I would've expect to be exposed with exact same firmware
information.
I understood that this was one of the main reasons why ACPI/SMBIOS
generation was moved from SeaBIOS to QEMU.
If you think this isn't the case, I can just remove this flag (Makes code
simpler). What do you prefer?
Thanks for the review,
-Liran
I'm inclined to agree, but no biggie if Igor disagrees let's go along
with his opinion.
I will wait for Igor's reply on this before I submit v2 (I have it ready
with the flag still existing).
To make sure that v2 passes all review comments. ;)
-Liran
