> > Ah I noticed only now... I just sent a series, the module_load_qom_all()
> > then is maybe something to discuss further.
> >
> > Thanks,
> >
> > Claudio
> >
>
> I noticed however that module_load_qom_all() does _not_ pass true for mayfail.
>
> You changed this behavior in:
>
> commit 9f4
On 9/6/22 13:59, Claudio Fontana wrote:
> On 9/6/22 11:53, Gerd Hoffmann wrote:
>>> In any case, the only thing that "mayfail" seems to control, is in
>>> module_load_file, and is a single printf:
>>>
>>> g_module = g_module_open(fname, flags);
>>> if (!g_module) {
>>> if (!mayfail
On 9/6/22 11:53, Gerd Hoffmann wrote:
>> In any case, the only thing that "mayfail" seems to control, is in
>> module_load_file, and is a single printf:
>>
>> g_module = g_module_open(fname, flags);
>> if (!g_module) {
>> if (!mayfail) {
>> fprintf(stderr, "Failed to op
> In any case, the only thing that "mayfail" seems to control, is in
> module_load_file, and is a single printf:
>
> g_module = g_module_open(fname, flags);
> if (!g_module) {
> if (!mayfail) {
> fprintf(stderr, "Failed to open module: %s\n",
> g_mo
On 9/5/22 16:43, Claudio Fontana wrote:
You might think 'mayfail' can be called by other code as true in some cases,
but no, it's always false.
I wonder why this "mayfail" argument exists and is propagated at all, when it
cannot be anything else than false.
I tried to remove the "mayfail" param
On 9/5/22 16:36, Claudio Fontana wrote:
> On 9/5/22 14:06, Richard Henderson wrote:
>> On 9/5/22 11:13, Claudio Fontana wrote:
>>> If module_load_one, module_load_file fail for any reason
>>> (permissions, plugin not installed, ...), we need to provide some
>>> notification
>>> to the user to unde
On 9/5/22 14:06, Richard Henderson wrote:
> On 9/5/22 11:13, Claudio Fontana wrote:
>> If module_load_one, module_load_file fail for any reason
>> (permissions, plugin not installed, ...), we need to provide some
>> notification
>> to the user to understand that this is happening; otherwise the er
On 9/5/22 11:13, Claudio Fontana wrote:
If module_load_one, module_load_file fail for any reason
(permissions, plugin not installed, ...), we need to provide some notification
to the user to understand that this is happening; otherwise the errors
reported on initialization will make no sense to t
If module_load_one, module_load_file fail for any reason
(permissions, plugin not installed, ...), we need to provide some notification
to the user to understand that this is happening; otherwise the errors
reported on initialization will make no sense to the user.
Signed-off-by: Claudio Fontana
