Re: [PATCH] accel: print an error message and exit if plugin not loaded

[Richard Henderson]

On 9/5/22 16:43, Claudio Fontana wrote:
You might think 'mayfail' can be called by other code as true in some cases, 
but no, it's always false.
I wonder why this "mayfail" argument exists and is propagated at all, when it 
cannot be anything else than false.
I tried to remove the "mayfail" parameter completely and things seem just fine.
In any case, the only thing that "mayfail" seems to control, is in 
module_load_file, and is a single printf:

     g_module = g_module_open(fname, flags);
     if (!g_module) {
         if (!mayfail) {
             fprintf(stderr, "Failed to open module: %s\n",
                     g_module_error());
         }
         ret = -EINVAL;
         goto out;
     }


Weird.. Is someone building proprietary modules on top of QEMU? Is this what 
this is currently trying to address?
But then, the result is just a printf...

I thought it was for things like vga_interface_available, which probes for the vga 
modules, but then gracefully handles an error.

There's definitely something wrong with the plumbing here.


r~