Re: [PATCH] 9pfs: Fix some return statements in the synth backend

2022-11-28 Thread Christian Schoenebeck
On Monday, November 28, 2022 11:18:48 AM CET Markus Armbruster wrote: > Greg Kurz writes: > > > On Mon, 28 Nov 2022 08:35:22 +0100 > > Markus Armbruster wrote: > > > >> Greg Kurz writes: > >> > >> > The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions > >> > currently return a

Re: [PATCH] 9pfs: Fix some return statements in the synth backend

2022-11-28 Thread Markus Armbruster
Greg Kurz writes: > On Mon, 28 Nov 2022 08:35:22 +0100 > Markus Armbruster wrote: > >> Greg Kurz writes: >> >> > The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions >> > currently return a positive errno value on failure. This causes >> > checkpatch.pl to spit several errors l

Re: [PATCH] 9pfs: Fix some return statements in the synth backend

2022-11-28 Thread Greg Kurz
On Mon, 28 Nov 2022 08:35:22 +0100 Markus Armbruster wrote: > Greg Kurz writes: > > > The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions > > currently return a positive errno value on failure. This causes > > checkpatch.pl to spit several errors like the one below: > > > > ERR

Re: [PATCH] 9pfs: Fix some return statements in the synth backend

2022-11-27 Thread Markus Armbruster
Greg Kurz writes: > The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions > currently return a positive errno value on failure. This causes > checkpatch.pl to spit several errors like the one below: > > ERROR: return of an errno should typically be -ve (return -EAGAIN) > #79: FILE:

Re: [PATCH] 9pfs: Fix some return statements in the synth backend

2022-11-26 Thread Christian Schoenebeck
On Thursday, November 24, 2022 4:58:38 PM CET Greg Kurz wrote: > The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions > currently return a positive errno value on failure. This causes > checkpatch.pl to spit several errors like the one below: > > ERROR: return of an errno should ty

[PATCH] 9pfs: Fix some return statements in the synth backend

2022-11-24 Thread Greg Kurz
The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions currently return a positive errno value on failure. This causes checkpatch.pl to spit several errors like the one below: ERROR: return of an errno should typically be -ve (return -EAGAIN) #79: FILE: hw/9pfs/9p-synth.c:79: +