Greg Kurz <gr...@kaod.org> writes: > The qemu_v9fs_synth_mkdir() and qemu_v9fs_synth_add_file() functions > currently return a positive errno value on failure. This causes > checkpatch.pl to spit several errors like the one below: > > ERROR: return of an errno should typically be -ve (return -EAGAIN) > #79: FILE: hw/9pfs/9p-synth.c:79: > + return EAGAIN; > > Simply change the sign. This has no consequence since callers > assert() the returned value to be equal to 0.
Out of curiosity: why is assert() appropriate? > While here also get rid of the uneeded ret variables as suggested > by return_directly.cocci. > > Reported-by: Markus Armbruster <arm...@redhat.com> > Signed-off-by: Greg Kurz <gr...@kaod.org> Signed-off-by: Markus Armbruster <arm...@redhat.com>
