i386: removes microvm from default build since microvm doesn't support Xen
accel.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2294
Signed-off-by: Will Gyda
---
configs/devices/i386-softmmu/default.mak | 1 -
hw/i386/Kconfig | 2 ++
2 files chang
Issue #2294: Machine microvm doesn't run under Xen accel for
qemu-system-x86_64.
Solution: microvm is now not build if only Xen is available.
Signed-off-by: Will Gyda
---
configs/devices/i386-softmmu/default.mak | 2 +-
hw/i386/Kconfig | 2 ++
2 files chang
migration/ram.c: API Conversion qemu_mutex_lock(),
and qemu_mutex_unlock() to WITH_QEMU_LOCK_GUARD macro
Signed-off-by: Will Gyda
---
migration/ram.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
index a975c5af16..50df1e9cd2
ed in 9pfs, we need to
> > > > > design this function to be tolerant with transient states as well.
> The
> > > > > use of chmod() is not safe when we consider about transient
> states. A
> > > > > malicious actor may replace the file at the path with a
dev)
> if (pthread_fchdir_np(dirfd) < 0) {
> return -1;
> }
> -err = mknod(filename, mode, dev);
> +if (S_ISSOCK(mode)) {
> +err = create_socket_file_at_cwd(filename, mode);
> +} else {
> +err = mknod(filename, mode, dev);
> +}
> preserved_errno = errno;
> /* Stop using the thread-local cwd */
> pthread_fchdir_np(-1);
> --
> 2.32.0 (Apple Git-132)
> Reviewed-by: Will Cohen
, mode);
> +}
> if (!pthread_fchdir_np) {
> error_report_once("pthread_fchdir_np() not available on this
> version of macOS");
> return -ENOTSUP;
> --
> 2.32.0 (Apple Git-132)
>
Reviewed-by: Will Cohen
>
>
On Thu, Mar 31, 2022 at 4:00 PM Peter Maydell
wrote:
> On Thu, 31 Mar 2022 at 19:27, Will Cohen wrote:
> >
> > The patch set adding 9p functionality to darwin introduced an issue
> > where limits.h, which defines XATTR_SIZE_MAX, is included in 9p.c,
> > though the re
in 9p.c.
Additionally, this commit moves the location of the system headers
include in 9p.c to occur before the project headers.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/950
Fixes: 38d7fd68b0 ("9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX")
Signed-off-by: Will C
On Thu, Mar 31, 2022 at 11:34 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Donnerstag, 31. März 2022 15:19:24 CEST Will Cohen wrote:
> > On Thu, Mar 31, 2022 at 7:07 AM Christian Schoenebeck <
> >
> > qemu_...@crudebyte.com> wrote:
> >
On Thu, Mar 31, 2022 at 7:07 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Donnerstag, 31. März 2022 10:03:35 CEST Peter Maydell wrote:
> > On Wed, 30 Mar 2022 at 22:55, Will Cohen wrote:
> > > On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell <
> pet
On Wed, Mar 30, 2022 at 5:31 PM Peter Maydell
wrote:
> On Wed, 30 Mar 2022 at 19:26, Will Cohen wrote:
> >
> > As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within
> > the patch set adding 9p functionality to darwin, the commit
> > 38d7fd68b0c87
On Wed, Mar 30, 2022 at 4:24 PM Philippe Mathieu-Daudé <
philippe.mathieu.da...@gmail.com> wrote:
> Hi,
>
> On 30/3/22 20:19, Will Cohen wrote:
> > As noted by https://gitlab.com/qemu-project/qemu/-/issues/950, within
> > the patch set adding 9p function
in 9p.h. This commit fixes that issue by
moving the include to 9p.h.
Signed-off-by: Will Cohen
---
hw/9pfs/9p.c | 5 -
hw/9pfs/9p.h | 5 +
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index dcaa602d4c..59c531ed47 100644
--- a/hw/9pfs/9p.c
!!(modifiers & NSEventModifierFlagCommand)) {
> -[self toggleKey:Q_KEY_CODE_META_R];
> +if (swap_opt_cmd) {
> +[self toggleKey:Q_KEY_CODE_ALT_R];
> +} else {
> +[self toggleKey:Q_KEY_CODE_META_R];
> +}
> }
> break;
> }
> @@ -2134,6 +2160,9 @@ static void cocoa_display_init(DisplayState *ds,
> DisplayOptions *opts)
> if (opts->has_show_cursor && opts->show_cursor) {
> cursor_hide = 0;
> }
> +if (opts->u.cocoa.has_swap_opt_cmd) {
> +swap_opt_cmd = opts->u.cocoa.swap_opt_cmd;
> +}
>
> if (opts->u.cocoa.has_left_command_key &&
> !opts->u.cocoa.left_command_key) {
> left_command_key_enabled = 0;
> --
> 2.34.1
>
> Reviewed-by: Will Cohen
lease(eventsTap);
> +}
> +
> [super dealloc];
> }
>
> @@ -655,6 +675,36 @@ QemuCocoaView *cocoaView;
> }
> }
>
> +- (void) setFullGrab:(id)sender
> +{
> +COCOA_DEBUG("QemuCocoaView: setFullGrab\n");
> +
> +CGEventM
On Fri, Mar 4, 2022 at 4:31 PM Will Cohen wrote:
> On Fri, Mar 4, 2022 at 3:16 PM Christian Schoenebeck <
> qemu_...@crudebyte.com> wrote:
>
>> On Freitag, 4. März 2022 19:42:18 CET Peter Maydell wrote:
>> > On Fri, 4 Mar 2022 at 12:32, Christian Schoenebec
til.h b/hw/9pfs/9p-util.h
> index cfa7af43c5..97e681e167 100644
> --- a/hw/9pfs/9p-util.h
> +++ b/hw/9pfs/9p-util.h
> @@ -54,7 +54,9 @@ static inline int openat_file(int dirfd, const char
> *name,
> int flags,
> {
> int fd, serrno, ret;
>
> +#ifndef CONFIG_DARWI
On Tue, Mar 1, 2022 at 2:25 PM Christian Schoenebeck
wrote:
> On Sonntag, 27. Februar 2022 23:35:11 CET Will Cohen wrote:
> > This is a followup to
> > https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg04391.html,
> adding
> > 9p server support for Darwin.
> &g
On Mon, Feb 28, 2022 at 8:20 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Sonntag, 27. Februar 2022 23:35:20 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > Darwin does not support mknodat. However, to avoid race conditions
> > with later
On Mon, Feb 28, 2022 at 8:11 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Sonntag, 27. Februar 2022 23:35:22 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > To allow VirtFS on darwin, we need to check that pthread_fchdir_np is
> > availab
[Will Cohen: - Add explanation of patch and description
of pre-patch test failure]
Signed-off-by: Will Cohen
Acked-by: Thomas Huth
[Will Cohen: - Move this patch before 9p: darwin: meson
patch to avoid qtest breakage during
bisecting]
Signed-off-by: Will
Roitzsch
[Will Cohen: - Adjust coding style
- Replace clang references with gcc
- Note radar filed with Apple for missing syscall
- Replace direct syscall with pthread_fchdir_np and
adjust patch notes accordingly
- Declare
From: Keno Fischer
This implements the darwin equivalent of the functions that were
moved to 9p-util(-linux) earlier in this series in the new
9p-util-darwin file.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
this functionality could be implemented later on.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Rebase to master]
Signed-off-by: Will Cohen
Reviewed-by: Paolo Bonzini
[Will Cohen: - Add check for pthread_fchdir_np to virtfs
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
Because XATTR_SIZE_MAX is not defined on Darwin,
create a cross-platform P9_XATTR_SIZE_MAX instead.
[Will Cohen: - Adjust coding style
- Lower XATTR_SIZE_MAX to 64k
- Add explanatory
From: Keno Fischer
The current file only has the Linux versions of these functions.
Rename the file accordingly and update the Makefile to only build
it on Linux. A Darwin version of these will follow later in the
series.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS
er.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen
---
hw/9pfs/9p-util.h | 2 ++
hw/9pfs/9p.c | 13 -
2 files changed, 14 insertions(+), 1 deletion(-)
diff --g
Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust to pass testing
- Ensure that d_seekoff is filled using telldir
on darwin, and create qemu_dirent_off helper
to decide which to access]
[Fabian Franz
From: Keno Fischer
On darwin `fgetxattr` takes two extra optional arguments,
and the l* variants are not defined (in favor of an extra
flag to the regular variants.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
[Will Cohen: - Note lack of f_namelen and f_frsize on Darwin
- Ensure that tv_sec and tv_nsec are both
initialized for Darwin and non-Darwin]
Signed-off-by: Will Cohen
---
hw/9pfs/9p
ly be an additional
optimization later.
[Will Cohen: - Fix headers for Alpine
- Integrate statfs.h back into file-op-9p.h
- Remove superfluous header guards from file-opt-9p
- Add note about virtfs-proxy-helper being disabled
on non-Linux for
tFS on Darwin
Will Cohen (1):
9p: darwin: Adjust assumption on virtio-9p-test
fsdev/file-op-9p.h | 9 ++-
fsdev/meson.build | 1 +
hw/9pfs/9p-local.c | 27 +--
hw/9pfs/9p-proxy.c | 38 +-
hw/9pfs/9p-s
On Fri, Feb 25, 2022 at 11:31 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Freitag, 25. Februar 2022 15:00:40 CET Will Cohen wrote:
> > On Tue, Feb 22, 2022 at 9:27 AM Christian Schoenebeck <
> >
> > qemu_...@crudebyte.com> wrote:
> > >
On Tue, Feb 22, 2022 at 9:27 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Sonntag, 20. Februar 2022 17:50:54 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > Darwin does not support mknodat. However, to avoid race conditions
> > with later
Apologies — I tested on Mac but should have done Linux too. Will revise.
On Sun, Feb 20, 2022 at 4:28 PM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Sonntag, 20. Februar 2022 17:50:49 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > On darw
this functionality could be implemented later on.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Rebase to master]
Signed-off-by: Will Cohen
Reviewed-by: Paolo Bonzini
[Will Cohen: - Add check for pthread_fchdir_np to virtfs
[Will Cohen: - Add explanation of patch and description
of pre-patch test failure]
Signed-off-by: Will Cohen
Acked-by: Thomas Huth
[Will Cohen: - Move this patch before 9p: darwin: meson
patch to avoid qtest breakage during
bisecting]
Signed-off-by: Will
From: Keno Fischer
This implements the darwin equivalent of the functions that were
moved to 9p-util(-linux) earlier in this series in the new
9p-util-darwin file.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
From: Keno Fischer
On darwin `fgetxattr` takes two extra optional arguments,
and the l* variants are not defined (in favor of an extra
flag to the regular variants.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
Roitzsch
[Will Cohen: - Adjust coding style
- Replace clang references with gcc
- Note radar filed with Apple for missing syscall
- Replace direct syscall with pthread_fchdir_np and
adjust patch notes accordingly
- Move qemu_mknodat
Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust to pass testing
- Ensure that d_seekoff is filled using telldir
on darwin, and create qemu_dirent_off helper
to decide which to access]
[Fabian Franz
ly be an additional
optimization later.
[Will Cohen: - Fix headers for Alpine
- Integrate statfs.h back into file-op-9p.h
- Remove superfluous header guards from file-opt-9p
- Add note about virtfs-proxy-helper being disabled
on non-Linux for
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
Because XATTR_SIZE_MAX is not defined on Darwin,
create a cross-platform P9_XATTR_SIZE_MAX instead.
[Will Cohen: - Adjust coding style
- Lower XATTR_SIZE_MAX to 64k
- Add explanatory
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
[Will Cohen: - Note lack of f_namelen and f_frsize on Darwin
- Ensure that tv_sec and tv_nsec are both
initialized for Darwin and non-Darwin]
Signed-off-by: Will Cohen
---
hw/9pfs/9p
From: Keno Fischer
The current file only has the Linux versions of these functions.
Rename the file accordingly and update the Makefile to only build
it on Linux. A Darwin version of these will follow later in the
series.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS
darwin: Implement compatibility for mknodat
9p: darwin: meson: Allow VirtFS on Darwin
Will Cohen (1):
9p: darwin: Adjust assumption on virtio-9p-test
fsdev/file-op-9p.h | 9 +++-
fsdev/meson.build | 1 +
hw/9pfs/9p-local.c | 27 -
er.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen
---
hw/9pfs/9p-util.h | 2 ++
hw/9pfs/9p.c | 13 -
2 files changed, 14 insertions(+), 1 deletion(-)
diff --g
Excellent, thanks so much for the update. I'll wait till the other 9p pull
gets integrated, then rebase and test!
On Fri, Feb 18, 2022 at 12:45 PM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Freitag, 18. Februar 2022 18:04:24 CET Will Cohen wrote:
> > On Tue,
On Tue, Feb 15, 2022 at 2:04 PM Will Cohen wrote:
> This is a followup to
> https://lists.gnu.org/archive/html/qemu-devel/2022-02/msg02313.html,
> adding 9p server support for Darwin.
>
> Since v6, the following changes have been made to the following patches:
>
> P
[Will Cohen: - Add explanation of patch and description
of pre-patch test failure]
Signed-off-by: Will Cohen
Acked-by: Thomas Huth
[Will Cohen: - Move this patch before 9p: darwin: meson
patch to avoid qtest breakage during
bisecting]
Signed-off-by: Will
Roitzsch
[Will Cohen: - Adjust coding style
- Replace clang references with gcc
- Note radar filed with Apple for missing syscall
- Replace direct syscall with pthread_fchdir_np and
adjust patch notes accordingly
- Move qemu_mknodat
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
Because XATTR_SIZE_MAX is not defined on Darwin,
create a cross-platform P9_XATTR_SIZE_MAX instead.
[Will Cohen: - Adjust coding style
- Lower XATTR_SIZE_MAX to 64k
- Add explanatory
From: Keno Fischer
The current file only has the Linux versions of these functions.
Rename the file accordingly and update the Makefile to only build
it on Linux. A Darwin version of these will follow later in the
series.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS
ly be an additional
optimization later.
[Will Cohen: - Fix headers for Alpine
- Integrate statfs.h back into file-op-9p.h
- Remove superfluous header guards from file-opt-9p
- Add note about virtfs-proxy-helper being disabled
on non-Linux for
9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX
9p: darwin: *xattr_nofollow implementations
9p: darwin: Compatibility for f/l*xattr
9p: darwin: Implement compatibility for mknodat
9p: darwin: meson: Allow VirtFS on Darwin
Will Cohen (1):
9p: darwin: Adjust assumption on virtio-9
er.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen
---
hw/9pfs/9p-util.h | 2 ++
hw/9pfs/9p.c | 13 -
2 files changed, 14 insertions(+), 1 deletion(-)
diff --g
From: Keno Fischer
On darwin `fgetxattr` takes two extra optional arguments,
and the l* variants are not defined (in favor of an extra
flag to the regular variants.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
From: Keno Fischer
This implements the darwin equivalent of the functions that were
moved to 9p-util(-linux) earlier in this series in the new
9p-util-darwin file.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust to pass testing
- Ensure that d_seekoff is filled using telldir
on darwin, and create qemu_dirent_off helper
to decide which to access]
[Fabian Franz
this functionality could be implemented later on.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Rebase to master]
Signed-off-by: Will Cohen
Reviewed-by: Paolo Bonzini
[Will Cohen: - Add check for pthread_fchdir_np to virtfs
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
[Will Cohen: - Note lack of f_namelen and f_frsize on Darwin
- Ensure that tv_sec and tv_nsec are both
initialized for Darwin and non-Darwin]
Signed-off-by: Will Cohen
---
hw/9pfs/9p
ItemWithTitle:@"Hide QEMU" action:@selector(hide:)
> keyEquivalent:@"h"]; //Hide QEMU
> menuItem = (NSMenuItem *)[menu addItemWithTitle:@"Hide Others"
> action:@selector(hideOtherApplications:) keyEquivalent:@"h"]; // Hide
> Others
> [menuItem
> setKeyEquivalentModifierMask:(NSEventModifierFlagOption|NSEventModifierFlagCommand)];
> --
> 2.34.1
>
Reviewed-by: Will Cohen
Tested-by: Will Cohen
Hello all,
I'm seeing on the updated release schedule that we're now looking at March
8 for soft feature freeze (
https://wiki.qemu.org/Planning/7.0#Release_Schedule). Is there anything
additional that should be prepared for this patch set to hopefully be able
to target 7.0?
Will
On T
On Wed, Feb 9, 2022 at 6:10 PM Akihiko Odaki
wrote:
> On Thu, Feb 10, 2022 at 3:20 AM Will Cohen wrote:
> >
> > On Wed, Feb 9, 2022 at 9:08 AM Christian Schoenebeck <
> qemu_...@crudebyte.com> wrote:
> >>
> >> On Mittwoch, 9. Februar 2022 14:33:25 CE
From: Keno Fischer
On darwin `fgetxattr` takes two extra optional arguments,
and the l* variants are not defined (in favor of an extra
flag to the regular variants.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
Roitzsch
[Will Cohen: - Adjust coding style
- Replace clang references with gcc
- Note radar filed with Apple for missing syscall
- Replace direct syscall with pthread_fchdir_np and
adjust patch notes accordingly
- Move qemu_mknodat
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
[Will Cohen: - Note lack of f_namelen and f_frsize on Darwin
- Ensure that tv_sec and tv_nsec are both
initialized for Darwin and non-Darwin]
Signed-off-by: Will Cohen
---
hw/9pfs/9p
er.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen
---
hw/9pfs/9p-util.h | 2 ++
hw/9pfs/9p.c | 13 -
2 files changed, 14 insertions(+), 1 deletion(-)
diff --g
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
Because XATTR_SIZE_MAX is not defined on Darwin,
create a cross-platform P9_XATTR_SIZE_MAX instead.
[Will Cohen: - Adjust coding style
- Lower XATTR_SIZE_MAX to 64k
- Add explanatory
Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust to pass testing
- Ensure that d_seekoff is filled using telldir
on darwin, and create qemu_dirent_off helper
to decide which to access]
[Fabian Franz
ly be an additional
optimization later.
[Will Cohen: - Fix headers for Alpine
- Integrate statfs.h back into file-op-9p.h
- Remove superfluous header guards from file-opt-9p
- Add note about virtfs-proxy-helper being disabled
on non-Linux for
DIRECT}
9p: darwin: Move XATTR_SIZE_MAX->P9_XATTR_SIZE_MAX
9p: darwin: *xattr_nofollow implementations
9p: darwin: Compatibility for f/l*xattr
9p: darwin: Implement compatibility for mknodat
9p: darwin: meson: Allow VirtFS on Darwin
Will Cohen (1):
9p: darwin: Adjust assumption on
this functionality could be implemented later on.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Rebase to master]
Signed-off-by: Will Cohen
Reviewed-by: Paolo Bonzini
[Will Cohen: - Add check for pthread_fchdir_np to virtfs
[Will Cohen: - Add explanation of patch and description
of pre-patch test failure]
Signed-off-by: Will Cohen
Acked-by: Thomas Huth
[Will Cohen: - Move this patch before 9p: darwin: meson
patch to avoid qtest breakage during
bisecting]
Signed-off-by: Will
From: Keno Fischer
The current file only has the Linux versions of these functions.
Rename the file accordingly and update the Makefile to only build
it on Linux. A Darwin version of these will follow later in the
series.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS
From: Keno Fischer
This implements the darwin equivalent of the functions that were
moved to 9p-util(-linux) earlier in this series in the new
9p-util-darwin file.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
On Wed, Feb 9, 2022 at 9:08 AM Christian Schoenebeck
wrote:
> On Mittwoch, 9. Februar 2022 14:33:25 CET Akihiko Odaki wrote:
> > > I like the idea of switching it to __attribute__((weak)). I should note
> > > that I'm not sure that I can actually fully test this out since I'm
> > > getting stuck
On Tue, Feb 8, 2022 at 2:49 PM Christian Schoenebeck
wrote:
> On Dienstag, 8. Februar 2022 19:28:21 CET Christian Schoenebeck wrote:
> > On Dienstag, 8. Februar 2022 19:04:31 CET Will Cohen wrote:
> > > On Tue, Feb 8, 2022 at 11:19 AM Will Cohen wrote:
> > > > O
On Tue, Feb 8, 2022 at 11:19 AM Will Cohen wrote:
> On Tue, Feb 8, 2022 at 11:11 AM Christian Schoenebeck <
> qemu_...@crudebyte.com> wrote:
>
>> On Dienstag, 8. Februar 2022 16:57:55 CET Will Cohen wrote:
>> > My inclination is to go with the __builtin_available(ma
On Tue, Feb 8, 2022 at 11:11 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Dienstag, 8. Februar 2022 16:57:55 CET Will Cohen wrote:
> > My inclination is to go with the __builtin_available(macOS 10.12, *)
> path,
> > if acceptable, since it partially m
oping for the best. With any luck, the distinction between the two
approaches will be moot, if we try to assume that a future macOS version
that removes this also provides mknodat.
On Tue, Feb 8, 2022 at 10:03 AM Christian Schoenebeck <
qemu_...@crudebyte.com> wrote:
> On Dienstag, 8. F
On Tue, Feb 8, 2022 at 7:20 AM Christian Schoenebeck
wrote:
> On Montag, 7. Februar 2022 23:40:19 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > Signed-off-by: Keno Fischer
> > Signed-off-by: Michael Roitzsch
> >
> > Because XATTR_SIZE_MAX is no
On Mon, Feb 7, 2022 at 5:56 PM Christian Schoenebeck
wrote:
> On Montag, 7. Februar 2022 23:40:22 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > Darwin does not support mknodat. However, to avoid race conditions
> > with later setting the permissions, we must a
On Mon, Feb 7, 2022 at 6:44 PM Christian Schoenebeck
wrote:
> On Montag, 7. Februar 2022 23:40:23 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > To allow VirtFS on darwin, we need to check that pthread_fchdir_np is
> > available, which has only been
this functionality could be implemented later on.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Rebase to master]
Signed-off-by: Will Cohen
Reviewed-by: Paolo Bonzini
[Will Cohen: - Add check for pthread_fchdir_np to virtfs
From: Keno Fischer
On darwin `fgetxattr` takes two extra optional arguments,
and the l* variants are not defined (in favor of an extra
flag to the regular variants.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
On Mon, Feb 7, 2022 at 5:48 PM Christian Schoenebeck
wrote:
> On Montag, 7. Februar 2022 22:07:34 CET Will Cohen wrote:
> > On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck
> >
> > wrote:
> > > On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
Because XATTR_SIZE_MAX is not defined on Darwin,
create a cross-platform P9_XATTR_SIZE_MAX instead.
[Will Cohen: - Adjust coding style
- Lower XATTR_SIZE_MAX to 64k
- Add explanatory
Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust to pass testing
- Ensure that d_seekoff is filled using telldir
on darwin, and create qemu_dirent_off helper
to decide which to access]
[Fabian Franz
From: Keno Fischer
The current file only has the Linux versions of these functions.
Rename the file accordingly and update the Makefile to only build
it on Linux. A Darwin version of these will follow later in the
series.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS
From: Keno Fischer
This implements the darwin equivalent of the functions that were
moved to 9p-util(-linux) earlier in this series in the new
9p-util-darwin file.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
Signed-off-by: Will Cohen
er.
Signed-off-by: Keno Fischer
[Michael Roitzsch: - Rebase for NixOS]
Signed-off-by: Michael Roitzsch
[Will Cohen: - Adjust coding style]
Signed-off-by: Will Cohen
---
hw/9pfs/9p-util.h | 2 ++
hw/9pfs/9p.c | 13 -
2 files changed, 14 insertions(+), 1 deletion(-)
diff --g
ly be an additional
optimization later.
[Will Cohen: - Fix headers for Alpine
- Integrate statfs.h back into file-op-9p.h
- Remove superfluous header guards from file-opt-9p
- Add note about virtfs-proxy-helper being disabled
on non-Linux for
[Will Cohen: - Add explanation of patch and description
of pre-patch test failure]
Signed-off-by: Will Cohen
Acked-by: Thomas Huth
---
tests/qtest/virtio-9p-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qtest/virtio-9p-test.c b/tests/qtest/virtio-9p
From: Keno Fischer
Signed-off-by: Keno Fischer
Signed-off-by: Michael Roitzsch
[Will Cohen: - Note lack of f_namelen and f_frsize on Darwin
- Ensure that tv_sec and tv_nsec are both
initialized for Darwin and non-Darwin]
Signed-off-by: Will Cohen
---
hw/9pfs/9p
Roitzsch
[Will Cohen: - Adjust coding style
- Replace clang references with gcc
- Note radar filed with Apple for missing syscall
- Replace direct syscall with pthread_fchdir_np and
adjust patch notes accordingly
- Move qemu_mknodat
lement compatibility for mknodat
9p: darwin: meson: Allow VirtFS on Darwin
Will Cohen (1):
9p: darwin: Adjust assumption on virtio-9p-test
fsdev/file-op-9p.h | 9 +++-
fsdev/meson.build | 1 +
hw/9pfs/9p-local.c | 27 ---
hw/9pfs/9p-p
On Mon, Feb 7, 2022 at 4:07 PM Will Cohen wrote:
> On Mon, Feb 7, 2022 at 9:21 AM Christian Schoenebeck <
> qemu_...@crudebyte.com> wrote:
>
>> On Montag, 7. Februar 2022 11:57:25 CET Dr. David Alan Gilbert wrote:
>> > * Greg Kurz (gr...@kaod.org) wrote:
>> &
> > > On 7/2/22 09:47, Greg Kurz wrote:
> > > > > On Sun, 6 Feb 2022 20:10:23 -0500
> > > > >
> > > > > Will Cohen wrote:
> > > > >> This patch set currently places it in 9p-util only because 9p is
> the
> > > &
On Mon, Feb 7, 2022 at 9:41 AM Christian Schoenebeck
wrote:
> On Sonntag, 6. Februar 2022 21:07:12 CET Will Cohen wrote:
> > From: Keno Fischer
> >
> > On darwin d_seekoff exists, but is optional and does not seem to
> > be commonly used by file systems. Use `telldir
1 - 100 of 299 matches
Mail list logo
