++
1 file changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Thomas Huth
functions.
+ */
+#pragma GCC poison g_slist_sort g_list_sort
+
/*
* Note that because of the GLIB_VERSION_MAX_ALLOWED constant above, allowing
* use of functions from newer GLib via this compat header needs a little
With the nit fixed:
Reviewed-by: Thomas Huth
avoid these issues, g_list_sort_with_data and
g_slist_sort_with_data should be used instead, as they do not rely on
function pointer casting.
Signed-off-by: Kohei Tokunaga
---
target/s390x/cpu_models.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Thomas Huth
erred.
But please address/comment on the nits that I found first.
Thanks,
Thomas
+++--
1 file changed, 23 insertions(+), 18 deletions(-)
Reviewed-by: Thomas Huth
g_assert_not_reached();
+}
+}
+
+#endif
Apart from the nits, patch looks good to me.
Thomas
rre,0xb9d4,%[val],%[ioaddr_len]\n"
+: [ioaddr_len] "+&d" (ioaddr_len.pair)
dito
+: [val] "d" (val)
+: "cc", "memory");
+}
...
+void s390x_pci_mmio_write_64(void *ioaddr, uint64_t val)
+{
+if (is_mio_supported) {
+ s390x_pcistgi(ioaddr, val, sizeof(val));
+} else {
+syscall(__NR_s390_pci_mmio_write, ioaddr, &val, sizeof(val));
+}
+}
+
FWIW, "git am" complains about "new blank line at EOF" here.
Apart from these nits, the patch looks sane to me.
Thomas
On 26/03/2025 11.43, Thomas Huth wrote:
On 11/03/2025 17.00, Kevin Wolf wrote:
From: Stefan Hajnoczi
Allow virtio-scsi virtqueues to be assigned to different IOThreads. This
makes it possible to take advantage of host multi-queue block layer
scalability by assigning virtqueues that have
From: Thomas Huth
The s390x tuxrun test lacks the call to self.set_machine(), so this
test is currently failing in case the 's390-ccw-virtio' machine has
not been compiled into the binary. Add the check now to fix it.
Signed-off-by: Thomas Huth
---
tests/functional/test_s390x_tux
From: Thomas Huth
The test_ppc64_linux_smt_boot function lacks the set_machine('pseries'),
so this test is currently failing in case the 'pseries' machine has not
been compiled into the binary. Add the check now to fix it.
Signed-off-by: Thomas Huth
---
tests/functional/t
xt+0xcab): undefined reference to
`pnv_chip_find_core'
/usr/bin/ld: libqemu-ppc64-softmmu.a.p/target_ppc_misc_helper.c.o: in
function `helper_store_sprd':
.../qemu/target/ppc/misc_helper.c:376:(.text+0xda3): undefined reference to
`pnv_chip_find_core'
collect2: error: ld returned 1 exit status
Could you please have a look?
Thanks,
Thomas
On 23/04/2025 11.31, Bernhard Beschow wrote:
Am 10. April 2025 06:05:35 UTC schrieb Thomas Huth :
On 09/04/2025 22.26, Bernhard Beschow wrote:
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since
the root filesystem resides on an SD card, the test also verifies
From: Thomas Huth
Since we don't run the Avocado jobs in the CI anymore, rename
these variables to QEMU_JOB_FUNCTIONAL and QEMU_CI_FUNCTIONAL.
Also, there was a mismatch between the documentation and the
implementation of QEMU_CI_AVOCADO_TESTING: While the documentation
said that you h
On 15/01/2025 08.38, Thomas Huth wrote:
Now that the v2.11 machine is gone, we don't need the v2.11 CPU
feature set anymore.
Signed-off-by: Thomas Huth
---
target/s390x/gen-features.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/target/s390x/gen-features.c b/target/s390
From: Thomas Huth
All tests that used this class have been converted to the functional
framework, so we can remove the boot_linux_console.py file now.
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250414113031.151105-6-th...@redhat.com>
Signed-off-by: Thomas Huth
---
tests/a
From: Thomas Huth
Some functional tests are currently not covered by the entries
in MAINTAINERS yet, so scripts/get_maintainers.pl fails to suggest
the right people who should be CC:-ed for related patches.
Add the uncovered tests to the right sections to close this gap.
Reviewed-by: Philippe
/machine: Make @dump-skeys command generic
Thomas Huth (23):
hw/s390x/s390-virtio-ccw: Remove the deprecated 2.9 machine type
hw/s390x/css: Remove the obsolete "css_migration_enabled" variable
hw/s390x/s390-stattrib: Remove the old migration_enabled flag
hw/intc/s390_fl
: Thomas Huth
Message-ID: <20250310151414.11550-2-phi...@linaro.org>
Signed-off-by: Thomas Huth
---
hw/s390x/s390-skeys.c | 39 +--
1 file changed, 17 insertions(+), 22 deletions(-)
diff --git a/hw/s390x/s390-skeys.c b/hw/s390x/s390-skeys.c
index 811d8
r": {"class": "GenericError", "desc": "Storage keys information not
available for this architecture"}}
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Message-ID: <20250310151414.11550-5-phi...@linaro.org>
Signed-off-by: Thomas Huth
From: Thomas Huth
This file was meant for defining the vocabulary for our testing
efforts, but it did not age well: First, the definitions are not
only about the CI part, but also about testing in general, so most
of the information should rather reside in main.rst instead.
Second, some
From: Thomas Huth
test_x86_64_pc in tests/avocado/boot_linux_console.py only checks
whether the kernel parameters have correctly been passed to the
kernel in the guest by looking for them in the console output of the
guest. Let's move that to the functional test framework now, but
inste
From: Thomas Huth
Reuse the test function from the 32-bit big endian test to easily
convert the 64-bit big endian Wheezy mips test.
Since this was the last test in tests/avocado/linux_ssh_mips_malta.py,
we can remove this avocado file now, too.
Reviewed-by: Daniel P. Berrangé
Message-ID
From: Thomas Huth
These tests are based on the cloudinit functions from Avocado.
The cloudinit is very, very slow compared to our other tests,
so most of these Avocado tests have either been disabled by default
with a decorator, or have been marked to only run with KVM.
We won't include
From: Thomas Huth
Now that the s390-ccw-virtio-2.9 machine type has been removed, we
don't need the "css_migration_enabled" variable anymore and can remove
the related code.
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20250115073819.15452-3-th...@redhat.com>
Signe
From: Thomas Huth
This test was using cloudinit and a "dnf install" command in the guest
to exercise the NIC with SMMU enabled. Since we don't have the cloudinit
stuff in the functional framework and we should not rely on having access
to external networks (once our ASSETs have b
From: Thomas Huth
Now that all Avocado tests have been converted to or been replaced by
other functional tests, we can delete the remainders of the Avocado
tests from the QEMU source tree.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250414113031.151
From: Thomas Huth
This way we can do a full boot in record-replay mode and
should get a similar test coverage compared to the old
replay test from tests/avocado/replay_linux.py.
Since the aarch64 test was the last avocado test in the
tests/avocado/replay_linux.py file, we can remove this
file
From: Thomas Huth
We are going to move the remaining Avocado tests step by step
into the functional test framework. Unfortunately, Avocado fails
with an error if it cannot determine a test to run, so disable
the tests here now to avoid failures in the Gitlab-CI during the
next steps.
Reviewed
From: Thomas Huth
Since this was the last test in tests/avocado/replay_kernel.py,
we can remove that Avocado file now.
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250414113031.151105-5-th...@redhat.com>
Signed-off-by: Thomas Huth
---
MAINTAINERS | 1 -
From: Cornelia Huck
Add 10.1 machine types for arm/i440fx/m68k/q35/s390x/spapr.
Signed-off-by: Cornelia Huck
Reviewed-by: Zhao Liu
Reviewed-by: Thomas Huth
Acked-by: Michael S. Tsirkin
Message-ID: <20250414094543.221241-1-coh...@redhat.com>
Signed-off-by: Thomas Huth
---
incl
From: Thomas Huth
pylint complains about these unnecessary import statements,
so let's remove them.
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20250414145457.261734-1-th...@redhat.com>
Signed-off-by: Thomas Huth
---
tests/functional/qemu_test/ports.py | 3
From: Thomas Huth
The test checks some entries in /proc and the output of some commands ...
we put these checks into exportable functions now so that they can
be reused more easily.
Additionally the linux_ssh_mips_malta.py uses SSH to test the networking
of the guest. Since we don't have
: Eric Farman
Reviewed-by: Thomas Huth
Message-ID: <20250310151414.11550-3-phi...@linaro.org>
Signed-off-by: Thomas Huth
---
include/hw/s390x/storage-keys.h | 15 +++
hw/s390x/s390-skeys.c | 5 +
2 files changed, 20 insertions(+)
diff --git a/include/hw/s390x/s
From: Thomas Huth
Reuse the test function from the big endian test to easily
convert the 32-bit little endian Wheezy mips test.
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250414113031.151105-8-th...@redhat.com>
Signed-off-by: Thomas Huth
---
tests/avocado/linux_ssh_mips_malta.p
From: Cornelia Huck
The test_change_password test will fail if no cryptographic backend is
available (e.g. if QEMU was built on a system with no cryptographic
library development packages installed); just skip the test in that
case.
Signed-off-by: Cornelia Huck
Reviewed-by: Thomas Huth
From: Thomas Huth
Yes, we are all C coders who try to write Python code for testing...
but still, let's better avoid semicolons at the end of the lines
to keep "pylint" happy!
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Nina Schoetterl-Glausch
Reviewed-by: Cédric Le Goa
From: Thomas Huth
Now that the machine types that set the migration_enabled flag to
false are gone, we can remove it and the related code.
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20250115073819.15452-4-th...@redhat.com>
Signed-off-by: Thomas Huth
---
include/hw/s390x/s
From: Thomas Huth
This way we can do a full boot in record-replay mode and
should get a similar test coverage compared to the old
replay test from tests/avocado/replay_linux.py. Thus remove
the x86 avocado replay_linux test now.
Reviewed-by: Daniel P. Berrangé
Message-ID
From: Thomas Huth
Reuse the test function from the 32-bit big endian test to easily
convert the 64-bit little endian Wheezy mips test.
Reviewed-by: Daniel P. Berrangé
Message-ID: <20250414113031.151105-9-th...@redhat.com>
Signed-off-by: Thomas Huth
---
tests/avocado/linux_ssh_mips_ma
From: Thomas Huth
These tests are using the gdb-related library functions from the
Avocado framework which we don't have in the functional framework
yet. So for the time being, keep those imports and skip the test
if the Avocado framework is not installed on the host.
Reviewed-by: Dan
From: Philippe Mathieu-Daudé
In preparation to make @dump-skeys command generic,
extract s390_qmp_dump_skeys() out of qmp_dump_skeys().
Register it as CCW qmp_dump_skeys() callback.
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
Reviewed-by: Eric Farman
Message-ID
From: Thomas Huth
Now that the machine types that set the migration_enabled flag to
false are gone, we can remove it and the related code.
Reviewed-by: Philippe Mathieu-Daudé
Message-ID: <20250115073819.15452-5-th...@redhat.com>
Signed-off-by: Thomas Huth
---
include/hw/s390x/s390_
From: Thomas Huth
The s390-ccw-virtio-2.9 machine is older than 6 years, so according to
our machine support policy, it can be removed now.
Message-ID: <20250115073819.15452-2-th...@redhat.com>
Signed-off-by: Thomas Huth
---
hw/s390x/s390-virtio-ccw.c | 24
,
+ .pv_rc = pv_resp.rc,
+ .diag_rc = DIAG_308_RC_INVAL_FOR_PV};
+
@Thomas: Is the formatting of the assignments correct or should there be no
assignment on lines containing "{}"?
Checkpatch is happy, though personally I find it hard to read.
I think I'd ra
On 22/04/2025 15.22, Stefan Hajnoczi wrote:
On Tue, Apr 22, 2025 at 9:09 AM Daniel P. Berrangé wrote:
On Tue, Apr 22, 2025 at 02:56:26PM +0200, Thomas Huth wrote:
From: Thomas Huth
Using "fedora:latest" now fails with Fedora 42:
Failed to resolve the transaction:
No
From: Thomas Huth
Using "fedora:latest" now fails with Fedora 42:
Failed to resolve the transaction:
No match for argument: python3.8
Switch back to Fedora 41 for the time being, to be able to still
test with Python 3.8.
Signed-off-by: Thomas Huth
---
tests/docker/d
problem. Do you know
whether there is a way to fix this again?
Thanks,
Thomas
rogram name and version
codes")
DEF_FEAT(DIAG_320, "diag320", SCLP_FAC134, 5, "Provide Certificate Store
functions")
+/* Features exposed via SCLP SCCB Facilities byte 136 - 137 (bit numbers relative to byte-136) */
+DEF_FEAT(SIPL, "sipl", SCLP_CBL, 1, "Seucre-IPL facility")
s/Seucre/Secure/
Thomas
eatures exposed via SCLP SCCB Facilities byte 136 - 137 (bit numbers relative to byte-136) */
DEF_FEAT(SIPL, "sipl", SCLP_CBL, 1, "Seucre-IPL facility")
+DEF_FEAT(SCLAF, "sclaf", SCLP_CBL, 3, "Seucre-IPL-code-loading-attributes
facility")
s/Seucre/Secure/
Thomas
r code complies with that GCompareFunc signature.
The cast is inside glib; g_list_sort casts the function pointer and calls
g_list_sort_with_data.
Did anybody already report this to the glib people? I guess it should get
fixed there in the long run...?
Thomas
From: Thomas Huth
Reuse the test function from the big endian test to easily
convert the 32-bit little endian Wheezy mips test.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
tests/avocado/linux_ssh_mips_malta.py | 8
tests/functional/meson.build | 1
On 14/04/2025 17.48, Gautam Gala wrote:
introduce a static function when exiting PV. The function replaces an
existing macro (s390_pv_cmd_exit).
You describe here what you're doing, but not why ... so may I ask: Why is
this change necessary?
Thomas
Signed-off-by: Gautam
the patch description!
Thanks,
Thomas
On Tue, Apr 15, 2025 at 11:44:35AM +0200, Thomas Huth wrote:
On 14/04/2025 17.48, Gautam Gala wrote:
introduce a static function when exiting PV. The function replaces an
existing macro (s390_pv_cmd_exit).
You describe here what you're doing, bu
--
python/qemu/qmp/qmp_tui.py| 12 ++--
python/qemu/utils/qom_fuse.py | 2 +-
python/setup.cfg | 8
3 files changed, 7 insertions(+), 15 deletions(-)
Reviewed-by: Thomas Huth
and pass that 64-bit result to the function.
Thanks,
Thomas
-void s390_pv_inject_reset_error(CPUState *cs)
+void s390_pv_inject_reset_error(CPUState *cs, uint64_t *resp)
{
int r1 = (cs->kvm_run->s390_sieic.ipa & 0x00f0) >> 4;
CPUS390XState *env = &S390_CPU
From: Thomas Huth
The s390-ccw-virtio-3.0 machine is older than 6 years, so according to
our machine support policy, it can be removed now.
Signed-off-by: Thomas Huth
---
hw/s390x/s390-virtio-ccw.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/hw/s390x/s390-virtio-ccw.c
From: Thomas Huth
pylint complains about these unnecessary import statements,
so let's remove them.
Signed-off-by: Thomas Huth
---
tests/functional/qemu_test/ports.py | 3 +--
tests/functional/qemu_test/tuxruntest.py | 2 --
tests/functional/qemu_test/uncompre
On 14/04/2025 16.37, Rorie Reyes wrote:
On 4/11/25 2:45 AM, Thomas Huth wrote:
#include CONFIG_DEVICES
at the beginning of the ioinst.c file. Then you should be able to do:
#ifdef CONFIG_VFIO_AP
if (s390_has_feat(S390_FEAT_AP)) {
return ap_chsc_sei_nt0_get_event(res);
}
#endif
These machine types are older than 6 years, so according to our new
support policy, it should be fine to remove them now in QEMU v10.1.
This series is
Based-on: <20250115073819.15452-1-th...@redhat.com>
Thomas Huth (4):
hw/s390x/s390-virtio-ccw: Remove the deprecated 3.0 machine typ
From: Thomas Huth
Reuse the test function from the 32-bit big endian test to easily
convert the 64-bit big endian Wheezy mips test.
Since this was the last test in tests/avocado/linux_ssh_mips_malta.py,
we can remove this avocado file now, too.
Reviewed-by: Daniel P. Berrangé
Signed-off-by
From: Thomas Huth
The s390-ccw-virtio-3.0 machine was the last one that used the
hpage_1m_allowed switch. Since we removed this machine type, we
can now remove the switch and the related code, too. This allows
us to get rid of the get_machine_class() hack and the big fat
warning comment there
From: Thomas Huth
The s390-ccw-virtio-4.0 machine is older than 6 years, so according to
our machine support policy, it can be removed now. The corresponding
v4.0 CPU feature group can now be removed, too.
Signed-off-by: Thomas Huth
---
hw/s390x/s390-virtio-ccw.c | 14 --
target
From: Thomas Huth
The s390-ccw-virtio-3.1 machine is older than 6 years, so according to
our machine support policy, it can be removed now. The corresponding
v3.1 CPU feature group can now be removed, too.
Signed-off-by: Thomas Huth
---
hw/s390x/s390-virtio-ccw.c | 16
From: Thomas Huth
These tests are based on the cloudinit functions from Avocado.
The cloudinit is very, very slow compared to our other tests,
so most of these Avocado tests have either been disabled by default
with a decorator, or have been marked to only run with KVM.
We won't include
From: Thomas Huth
Some functional tests are currently not covered by the entries
in MAINTAINERS yet, so scripts/get_maintainers.pl fails to suggest
the right people who should be CC:-ed for related patches.
Add the uncovered tests to the right sections to close this gap.
Signed-off-by: Thomas
insertions(+), 9 deletions(-)
Reviewed-by: Thomas Huth
Test("No cryptographic backend available")
else:
self.log.info("unhandled launch failure: %s", excp.output)
raise excp
Reviewed-by: Thomas Huth
From: Thomas Huth
This test was using cloudinit and a "dnf install" command in the guest
to exercise the NIC with SMMU enabled. Since we don't have the cloudinit
stuff in the functional framework and we should not rely on having access
to external networks (once our ASSETs have b
From: Thomas Huth
Now that all Avocado tests have been converted to or been replaced by
other functional tests, we can delete the remainders of the Avocado
tests from the QEMU source tree.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
From: Thomas Huth
Reuse the test function from the 32-bit big endian test to easily
convert the 64-bit little endian Wheezy mips test.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
tests/avocado/linux_ssh_mips_malta.py | 8
tests/functional/meson.build
From: Thomas Huth
All tests that used this class have been converted to the functional
framework, so we can remove the boot_linux_console.py file now.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
---
tests/avocado/boot_linux_console.py | 62 -
1 file
From: Thomas Huth
Since this was the last test in tests/avocado/replay_kernel.py,
we can remove that Avocado file now.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
-#
-# This work is licensed under the terms of the GNU GPL, version 2 or
-# later. See the COPYING file in the top
QEMU_CI_FUNCTIONAL
Thomas Huth (15):
gitlab-ci: Remove the avocado tests from the CI pipelines
tests/functional: Move the check for the parameters from avocado to
functional
tests/functional: Convert reverse_debugging tests to the functional
framework
tests/functional: Convert the i386 replay
From: Thomas Huth
Since we don't run the Avocado jobs in the CI anymore, rename
these variables to QEMU_JOB_FUNCTIONAL and QEMU_CI_FUNCTIONAL.
Also, there was a mismatch between the documentation and the
implementation of QEMU_CI_AVOCADO_TESTING: While the documentation
said that you h
From: Thomas Huth
This way we can do a full boot in record-replay mode and
should get a similar test coverage compared to the old
replay test from tests/avocado/replay_linux.py.
Since the aarch64 test was the last avocado test in the
tests/avocado/replay_linux.py file, we can remove this
file
From: Thomas Huth
This way we can do a full boot in record-replay mode and
should get a similar test coverage compared to the old
replay test from tests/avocado/replay_linux.py. Thus remove
the x86 avocado replay_linux test now.
Reviewed-by: Daniel P. Berrangé
Signed-off-by: Thomas Huth
From: Thomas Huth
The test checks some entries in /proc and the output of some commands ...
we put these checks into exportable functions now so that they can
be reused more easily.
Additionally the linux_ssh_mips_malta.py uses SSH to test the networking
of the guest. Since we don't have
From: Thomas Huth
We are going to move the remaining Avocado tests step by step
into the functional test framework. Unfortunately, Avocado fails
with an error if it cannot determine a test to run, so disable
the tests here now to avoid failures in the Gitlab-CI during the
next steps.
Reviewed
From: Thomas Huth
These tests are using the gdb-related library functions from the
Avocado framework which we don't have in the functional framework
yet. So for the time being, keep those imports and skip the test
if the Avocado framework is not installed on the host.
Signed-off-by: Thomas
From: Thomas Huth
test_x86_64_pc in tests/avocado/boot_linux_console.py only checks
whether the kernel parameters have correctly been passed to the
kernel in the guest by looking for them in the console output of the
guest. Let's move that to the functional test framework now, but
inste
On 26/03/2025 10.30, Daniel P. Berrangé wrote:
On Tue, Mar 25, 2025 at 09:00:11PM +0100, Thomas Huth wrote:
From: Thomas Huth
These tests are using the gdb-related library functions from the
Avocado framework which we don't have in the functional framework
yet. So for the time being,
On 26/03/2025 10.50, Daniel P. Berrangé wrote:
On Tue, Mar 25, 2025 at 09:00:22PM +0100, Thomas Huth wrote:
From: Thomas Huth
Since we don't run the Avocado jobs in the CI anymore, rename
these variables to QEMU_JOB_FUNCTIONAL and QEMU_CI_FUNCTIONAL_TESTING.
...
-QEMU_CI_AVOCADO_TE
but if the require_device() calls get too annoying one day, we can
reconsider.
Thomas
t = S390_IPL_TYPE_CCW;
Wouldn't it make sense to only do this iff the secure IPL is also used?
Thomas
chine option instead.
Thanks,
Thomas
509_crt_deinit(g_cert);
+}
+
+gnutls_pkcs7_deinit(sig);
+#else
+ rc = DIAG_508_RC_FAIL_VERIF;
+#endif /* CONFIG_GNUTLS */
+g_free(svb);
break;
default:
s390_program_interrupt(env, PGM_SPECIFICATION, ra);
Thomas
ult:
+s390_program_interrupt(env, PGM_SPECIFICATION, ra);
+return;
+}
+env->regs[r1 + 1] = rc;
+}
Thomas
s390_cpu_virt_mem_write(cpu, addr, (uint8_t)r1, &vcssb,
+be64_to_cpu(
And that be64_to_cpu() is wrong here.
Thomas
+
sizeof(VerificationCertificateStorageSizeBlock)
+))) {
+
ase DIAG_320_SUBC_QUERY_ISM:
+uint64_t ism = 0;
+
+if (s390_cpu_virt_mem_write(cpu, addr, (uint8_t)r1, &ism,
I think you could drop the (uint8_t) here?
+be64_to_cpu(sizeof(ism {
be64_to_cpu() looks very wrong here!
Thomas
IAG_318, model->features);
}
+set_bit(S390_FEAT_DIAG_320, model->features);
+
/* Test for Ultravisor features that influence secure guest behavior */
query_uv_feat_guest(model->features);
Thomas
cert_path_builder->len; i++) {
+S390IPLCertificate *qcert = NULL;
+if (init_cert((char *) cert_path_builder->pdata[i], &qcert) < 0) {
+continue;
Maybe invert the logic to call update_cert_store() in case of success, than
you don't need the "continue" anymore?
+}
+
+update_cert_store(cert_store, qcert);
+}
+
+g_ptr_array_free(cert_path_builder, true);
+}
Thomas
erts
See the other object_class_property_add() statements in
ccw_machine_class_init() for some examples how to do this.
Thomas
On 10/04/2025 22.31, Rorie Reyes wrote:
On 3/17/25 9:41 AM, Thomas Huth wrote:
On 11/03/2025 16.16, Rorie Reyes wrote:
Handle interception of the CHSC SEI instruction for requests
indicating the guest's AP configuration has changed.
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Kr
(Thomas)
* Omit fetch() (Thomas)
* Omit "-accel tcg" (Thomas)
* Add "snapshot=on" to make potential future tests independent
Supersedes: 20250405214900.7114-1-shen...@gmail.com
---
MAINTAINERS | 1 +
tests/functional/meson.build
+#!/usr/bin/env bash
#
# Author: Fam Zheng
#
Reviewed-by: Thomas Huth
On 03/04/2025 14.49, Shalini Chellathurai Saroja wrote:
On 2025-04-02 09:52, Thomas Huth wrote:
On 31/03/2025 16.00, Shalini Chellathurai Saroja wrote:
Add Control-Program Identification (CPI) device to QOM only when the virtual
machine supports CPI. CPI is supported from "s390-ccw-virtio
T(cpi, SCLPDevice, 0, vmstate_control_program_id,
+ ControlProgramId),
+ VMSTATE_END_OF_LIST()
+ }
+};
+
static void sclp_class_init(ObjectClass *oc, void *data)
{
SCLPDeviceClass *sc = SCLP_CLASS(oc);
@@ -438,6 +461,7 @@ static void sclp_class_init(Object
smp', '4',
+ '-accel', 'tcg',
The imx8mp-evk board has a "depends on TCG" in its Kconfig file, so I think
you could omit "-accel tcg" here (but it also does not hurt to be explicit,
I guess).
Thomas
+
On 24/03/2025 17.32, Philippe Mathieu-Daudé wrote:
On 24/3/25 10:30, Thomas Huth wrote:
On 23/03/2025 23.40, Philippe Mathieu-Daudé wrote:
Register sparc_cpu_list() as CPUClass:list_cpus callback
and remove the cpu_list definition.
Copy-n-paste error in both, subject and patch description
From: Thomas Huth
These tests currently fail if VNC support has not been compiled into
the QEMU binary. Let's add some checks to skip the tests in that
case instead.
Signed-off-by: Thomas Huth
---
tests/functional/test_vnc.py | 26 ++
1 file changed, 22 inser
1 - 100 of 3507 matches
Mail list logo
