On 24/03/2025 17.32, Philippe Mathieu-Daudé wrote:
On 24/3/25 10:30, Thomas Huth wrote:
On 23/03/2025 23.40, Philippe Mathieu-Daudé wrote:
Register sparc_cpu_list() as CPUClass:list_cpus callback
and remove the cpu_list definition.
Copy-n-paste error in both, subject and patch description: This should be
about s390x, not sparc.
Oh oops.
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 5b7992deda6..1aac967a0ce 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -902,7 +902,6 @@ static inline uint8_t s390_cpu_get_state(S390CPU *cpu)
/* cpu_models.c */
void s390_cpu_list(void);
Don't you want to remove the prototype here, too? (and make the function
static in the .c file)
s390_set_qemu_cpu_model is defined in cpu_models.c,
while CPUClass in cpu.c.
Oh, right! So maybe you could move the prototype into cpu_models.h instead?
Thomas
