Re: [Qemu-devel] [PATCH] coroutine: Fix win32 variant for older mingw32 compilers

2012-11-21 Thread malc
On Wed, 21 Nov 2012, Jan Kiszka wrote: > On 2012-11-21 15:08, Paolo Bonzini wrote: > > Il 21/11/2012 15:00, Jan Kiszka ha scritto: > >> +if (!TlsGetValue(current_tls_index)) { > >> +leader = g_malloc0(sizeof(*leader)); > >> +leader->fiber = ConvertThreadToFiber(NULL); > >> +

[Qemu-devel] 879e45c72da1569e07fbbc6a1aa2a708ea796044 breakage

2012-11-20 Thread malc
Commit in the subject broke inet parsing (noticed by a build on a remote system without X and only internal vnc server that by default uses localhost:0,to=99), following was probably intended, but you're never sure: diff --git a/qemu-sockets.c b/qemu-sockets.c index cfed9c5..e7272c8 100644 --- a/

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Anthony Liguori wrote: > malc writes: [..snip..] > Hi malc, > > If you want to put code under the public domain, it needs to be done (1) > with the consent of all contributors to a file (2) using an appropriate > license. > > In QEMU, we'

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Markus Armbruster wrote: > malc writes: > > > On Tue, 20 Nov 2012, Markus Armbruster wrote: > > > >> malc writes: > >> > >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> > > >> >

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Paolo Bonzini wrote: > Il 20/11/2012 10:59, malc ha scritto: [..snip..] > > >> FSF says > > > > And what it says about CC0 or whatnot is utterly irrelevent. > > Surely their lawyers are better at copyright law than malc. Surely the

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-20 Thread malc
On Tue, 20 Nov 2012, Markus Armbruster wrote: > malc writes: > > > On Mon, 19 Nov 2012, Anthony Liguori wrote: > > > >> > >> "Public domain" is not a valid copyright header/license grant. > > > > Sez who? > Sez who was asked in

Re: [Qemu-devel] [GitHub] [Qemu-commits] [qemu/qemu] ecdffb: tcg/ppc: Remove unused s_bits variable

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Anthony Liguori wrote: > > "Public domain" is not a valid copyright header/license grant. Sez who? > > I'd suggest using something like CC0 which is a formal statement of > no copyright claims. > > http://www.ohloh.net/licenses/cc0-1-universal > > Please send these sorts

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Anthony Liguori wrote: > malc writes: > > > On Mon, 19 Nov 2012, Peter Maydell wrote: > > > >> On 19 November 2012 18:21, malc wrote: > >> > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> >> +5) Files without explici

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Stefan Weil wrote: > Am 19.11.2012 19:34, schrieb malc: > > On Mon, 19 Nov 2012, Peter Maydell wrote: > > > > > On 19 November 2012 18:21, malc wrote: > > > > On Mon, 19 Nov 2012, Anthony Liguori wrote: > > > > > +5) Fi

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Peter Maydell wrote: > On 19 November 2012 18:21, malc wrote: > > On Mon, 19 Nov 2012, Anthony Liguori wrote: > >> +5) Files without explicit licenses fall under the GPL v2. > > > > I have issue with this, files without licenses are just t

Re: [Qemu-devel] [PATCH] LICENSE: clarify licensing

2012-11-19 Thread malc
On Mon, 19 Nov 2012, Anthony Liguori wrote: > There's a couple changes here. Please note that no one should consider this > as > licensing guidance from IBM. I'm merely updating this based on what I would > consider community consensus. > > The first change clarifies that the overall license i

Re: [Qemu-devel] [PATCH] aio: fix aio_ctx_prepare with idle bottom halves

2012-11-12 Thread malc
On Mon, 12 Nov 2012, Paolo Bonzini wrote: > Commit ed2aec4867f0d5f5de496bb765347b5d0cfe113d changed the return > value of aio_ctx_prepare from false to true when only idle bottom > halves are available. This broke PC old-style DMA, which uses them. > Fix this by making aio_ctx_prepare return true

Re: [Qemu-devel] [PATCH] Revert "aio: clean up now-unused functions"

2012-11-09 Thread malc
On Sat, 10 Nov 2012, Paolo Bonzini wrote: > Il 09/11/2012 21:43, malc ha scritto: > > > > Breaks (at least) SB16. Apparently doesn't do what commit message says > > it does. > > > > This reverts commit 22bfa75eafc21522afbb265091faa9cc0649e9fb. > >

[Qemu-devel] [PATCH] Revert "aio: clean up now-unused functions"

2012-11-09 Thread malc
Breaks (at least) SB16. Apparently doesn't do what commit message says it does. This reverts commit 22bfa75eafc21522afbb265091faa9cc0649e9fb. --- async.c | 23 --- oslib-posix.c | 31 +++ qemu-aio.h|1 + qemu-common.h |1 + 4

Re: [Qemu-devel] [PATCH] tools: initialize main loop before block layer

2012-11-05 Thread malc
On Sat, 3 Nov 2012, Paolo Bonzini wrote: > Tools were broken because they initialized the block layer while > qemu_aio_context was still NULL. > > Reported-by: malc > Signed-off-by: Paolo Bonzini [..snip..] Applied, thanks. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH v8 0/3] tcg: enhance code generation quality for qemu_ld/st IRs

2012-11-01 Thread malc
On Wed, 31 Oct 2012, Yeongkyoon Lee wrote: > Here is the 8th version of the series optimizing TCG qemu_ld/st code > generation. > > v8: > - Rebase [..snip..] FWIW here's ppc32 implementation of your idea, thanks for explaining the motivation behind certain aspects in our private discussion.

Re: [Qemu-devel] [PATCH] HACKING: List areas where we may rely on impdef C behaviour

2012-10-30 Thread malc
On Tue, 30 Oct 2012, Peter Maydell wrote: > On 30 October 2012 16:40, malc wrote: > > On Tue, 30 Oct 2012, Peter Maydell wrote: > > > >> Add a section to HACKING describing the bits of implementation > >> defined C compiler behaviour which C code i

Re: [Qemu-devel] [PATCH] HACKING: List areas where we may rely on impdef C behaviour

2012-10-30 Thread malc
On Tue, 30 Oct 2012, Peter Maydell wrote: > Add a section to HACKING describing the bits of implementation > defined C compiler behaviour which C code in QEMU is allowed > to rely on. People who will desperately do a text search for "behaviour" in relevant standards will soon learn that the briti

Re: [Qemu-devel] [PATCH 03/12] hw/pl080: Use LOG_GUEST_ERROR and LOG_UNIMP

2012-10-25 Thread malc
On Thu, 25 Oct 2012, Peter Maydell wrote: > Use LOG_GUEST_ERROR and LOG_UNIMP in preference to hw_error(). It's weird that printing something + abort is replaced by just printing a message and the commit message doesn't really reflect the fact. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 2/2] target-arm: Implement abs_i32 inline rather than as a helper

2012-10-18 Thread malc
On Thu, 18 Oct 2012, Peter Maydell wrote: [..snip..] > > -/* FIXME: Implement this natively. */ > -#define tcg_gen_abs_i32(t0, t1) gen_helper_abs(t0, t1) > +static void tcg_gen_abs_i32(TCGv dest, TCGv src) > +{ > +TCGv c0 = tcg_const_i32(0); > +printf("tcg_gen_abs_i32\n"); ^^^

Re: [Qemu-devel] [PATCH 00/11] static patches

2012-10-14 Thread malc
On Sun, 14 Oct 2012, Blue Swirl wrote: > On Sun, Oct 14, 2012 at 7:58 PM, Blue Swirl wrote: > > I made a small tool to detect unused functions and > > variables. Here's some fixes. > > Just run the attached tool in an object directory and after some time, > it will produce a list of suspect symb

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-14 Thread malc
On Sun, 14 Oct 2012, Andriy Gapon wrote: [..snip..] > > Hmm... Since you are the author of the patch, wouldn't be more > appropriate for you to submit it? Besides, I can only mostly repeat the > bug report as I do not quite understand the code and can not properly > describe what the patch do

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-10 Thread malc
On Thu, 11 Oct 2012, Andriy Gapon wrote: > on 08/10/2012 12:02 Andriy Gapon said the following: > > on 08/10/2012 10:52 malc said the following: > >> On Mon, 8 Oct 2012, Andriy Gapon wrote: > >> > >>> > >>> I am running Qemu (plain, no kvm, et

Re: [Qemu-devel] bug in popcnt emulation with some register operand(s)?

2012-10-08 Thread malc
On Mon, 8 Oct 2012, Andriy Gapon wrote: > > I am running Qemu (plain, no kvm, etc) on an AMD 10h machine that > provides popcnt instruction. Qemu advertises availability of pocnt > to a guest as well. What I see in the guest that popcnt > 0x20(%r12),%r8 instruction actually placed its result in

Re: [Qemu-devel] [PATCH 1/2] linux-user: ppc: mark as long long aligned

2012-10-01 Thread malc
On Sun, 30 Sep 2012, Alexander Graf wrote: > The PPC32 ABI dictates that long long (64bit) parameters are pass in odd/even > register pairs. Because unlike ARM and MIPS we start at an odd register > number, > we can reuse the same aligning code that ARM and MIPS use. > > Signed-off-by: Alexander

Re: [Qemu-devel] [PATCH] audio: Fix warning from static code analysis

2012-09-22 Thread malc
On Sat, 22 Sep 2012, Stefan Weil wrote: > Am 03.09.2012 21:25, schrieb Stefan Weil: > > smatch report: > > audio/audio_template.h:416 AUD_open_out(18) warn: > > variable dereferenced before check 'as' (see line 414) > > > > Moving the ldebug statement after the statement which checks 'as' > > f

Re: [Qemu-devel] [PATCH 1/8] tcg: Adjust descriptions of *cond opcodes

2012-09-22 Thread malc
On Fri, 21 Sep 2012, Richard Henderson wrote: > The README file documented the operand ordering of the tcg_gen_* > functions. Since we're documenting opcodes here, use the true > operand ordering. Thanks, looks good. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH v2 0/7] tcg: movcond (ppc32 version)

2012-09-21 Thread malc
On Fri, 21 Sep 2012, Richard Henderson wrote: > On 09/21/2012 01:10 PM, malc wrote: > > +if (dest == v2) { > > +label_ptr = s->code_ptr; > > +tcg_out32 (s, tcg_to_bc[tcg_invert_cond (cond)]); > > +tcg_out_

Re: [Qemu-devel] [PATCH v2 0/7] tcg: movcond (ppc32 version)

2012-09-21 Thread malc
diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 26c4b33..0fb6fc7 100644 --- a/tcg/ppc/tcg-target.c +++ b/tcg/ppc/tcg-target.c @@ -390,6 +390,7 @@ static int tcg_target_const_match(tcg_target_long val, #define ORCXO31(412) #define EQVXO31(284) #define NAND XO31(476) +#def

Re: [Qemu-devel] [PATCH 0/2] target-xtensa: fix extui and gen_check_loop_end

2012-09-20 Thread malc
On Fri, 21 Sep 2012, Max Filippov wrote: > Max Filippov (2): > target-xtensa: fix extui shift amount > target-xtensa: don't emit extra tcg_gen_goto_tb > > target-xtensa/translate.c | 28 > 1 files changed, 24 insertions(+), 4 deletions(-) > Applied, thanks.

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-20 Thread malc
On Thu, 20 Sep 2012, Max Filippov wrote: > On Wed, Sep 19, 2012 at 11:53 PM, Richard Henderson wrote: > > On 09/19/2012 11:30 AM, Peter Maydell wrote: > >> ...but on the other hand that ought to work for PPC too, so > >> presumably my analysis is wrong somewhere. > > > > It isn't. It's a target-

Re: [Qemu-devel] [PATCH] arch_init.c: Improve '-soundhw help' for non-HAS_AUDIO_CHOICE archs

2012-09-19 Thread malc
On Wed, 19 Sep 2012, Peter Maydell wrote: > For architectures which don't set HAS_AUDIO_CHOICE, improve the > '-soundhw help' message so that it doesn't simply print an empty > list, implying no sound support at all. > [..snip..] Applied, thanks. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 0/5] tcg: movcond

2012-09-19 Thread malc
deferring the issue to the register > allocator instead of trying to do that in the backend. > > >From my side, I am ok with it. That said I'd also like to have at least > the opinion of Malc and Blue (Cc:ed). Comments from others are also > welcome. I don't hav

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread malc
On Wed, 19 Sep 2012, Max Filippov wrote: > On Tue, Sep 18, 2012 at 11:52 PM, malc wrote: > > > > Looks like PPC/PPC64 is also hit by shift issues, on top of that xtensa > > malc, could you please expand a little bit what are these shift issues? > (sounds like a modern t

Re: [Qemu-devel] Shifts, ppc[64], xtensa

2012-09-19 Thread malc
On Tue, 18 Sep 2012, Richard Henderson wrote: > On 09/18/2012 12:52 PM, malc wrote: > > case INDEX_op_shl_i32: > > if (const_args[2]) { > > +if (args[2] > 31) { > > +tcg_out_movi (s, TCG_TYPE_I32, 0, args[2]); > > +

[Qemu-devel] Shifts, ppc[64], xtensa

2012-09-18 Thread malc
Looks like PPC/PPC64 is also hit by shift issues, on top of that xtensa exposed another bug in power's tcg - gototb's target was expected to be always filled via tb_set_jmp_target (even though it's clearly not what tcg/README prescribes, sorry about that). Thanks to Max Filippov for pointing to

Re: [Qemu-devel] Breakage

2012-09-18 Thread malc
On Tue, 18 Sep 2012, Max Filippov wrote: > On Tue, Sep 18, 2012 at 12:15 AM, Eduardo Habkost wrote: > > On Mon, Sep 17, 2012 at 11:54:42PM +0400, malc wrote: > >> On Mon, 17 Sep 2012, Anthony Liguori wrote: > >> > >> > malc writes: > >> > &g

Re: [Qemu-devel] Breakage

2012-09-17 Thread malc
On Mon, 17 Sep 2012, Anthony Liguori wrote: > malc writes: > > > Some(thing|one) broke compilation with pcspk enabled. > > Symptoms being: > > > > ../libhw32/hw/pcspk.o: In function `pcspk_io_write': > > /home/malc/x/rcs/git/qemu/hw/pcspk.c:145:

[Qemu-devel] Breakage

2012-09-17 Thread malc
Some(thing|one) broke compilation with pcspk enabled. Symptoms being: ../libhw32/hw/pcspk.o: In function `pcspk_io_write': /home/malc/x/rcs/git/qemu/hw/pcspk.c:145: undefined reference to `pit_set_gate' ../libhw32/hw/pcspk.o: In function `pcspk_io_read': /home/malc/x/rcs/git/qemu

Re: [Qemu-devel] [PATCH 4/4] kvm: i386: Add classic PCI device assignment

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Anthony Liguori wrote: > Blue Swirl writes: > > > On Tue, Aug 28, 2012 at 5:28 PM, Michael S. Tsirkin wrote: > >> On Tue, Aug 28, 2012 at 05:01:55PM +, Blue Swirl wrote: > >>> On Tue, Aug 28, 2012 at 7:35 AM, Michael Tokarev wrote: > >>> > On 27.08.2012 22:56, Blue Swi

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Peter Maydell wrote: > On 28 August 2012 18:21, Michael S. Tsirkin wrote: > > We are talking about stuff like __kvm_pv_eoi - so the chance is exactly 0. > > And if it does happen then you run a simple script and fix > > this one instance. > > Why not just use a name that doe

Re: [Qemu-devel] [PATCH] HACKING: remove bogus restrictions

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Tue, Aug 28, 2012 at 05:24:40PM +0100, Peter Maydell wrote: > > On 28 August 2012 17:01, Michael S. Tsirkin wrote: > > > We copied HACKING from libvirt but it has some bogus stuff: > > > neither underscore capital, double underscore, or undersco

Re: [Qemu-devel] [PATCHv2 3/4] cpuid: disable pv eoi for 1.1 and older compat types

2012-08-28 Thread malc
On Tue, 28 Aug 2012, Michael S. Tsirkin wrote: > On Mon, Aug 27, 2012 at 07:40:56PM +, Blue Swirl wrote: > > On Mon, Aug 27, 2012 at 7:24 PM, Michael S. Tsirkin wrote: > > > On Mon, Aug 27, 2012 at 07:12:27PM +, Blue Swirl wrote: > > >> On Mon, Aug 27, 2012 at 7:06 PM, Michael S. Tsirkin

Re: [Qemu-devel] [PATCH]] audio: previous audio buffer should be flushed

2012-08-28 Thread malc
On Tue, 28 Aug 2012, munkyu.im wrote: > Winwave audio backend has problem with pausing and restart audio out. > Unlike other backends, Winwave pausing API does not flush audio buffer. > As a result, the previous audio data are playedin front of > user expected sound when user restart audio. > So c

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread malc
On Mon, 27 Aug 2012, Anthony Liguori wrote: > malc writes: > [..snip..] > > > > Number 2 was, and should stay, as the emulation wasn't correct before it, > > don't really care about the rest. > > Okay, please revert the rest then. > Done. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-27 Thread malc
On Mon, 27 Aug 2012, Anthony Liguori wrote: > malc writes: > > > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > > > >> After applying this version 2 of this patch series, I can > >> successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) >

Re: [Qemu-devel] [PATCH] linux-user: If loading fails, print error as string, not number

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Peter Maydell wrote: > If the attempt to load the guest executable fails, print the > error message as a string, not a number. This requires us to > fix a couple of places in loader_exec() where we were returning > -1 instead of a valid negative errno. > > The change allows u

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Andreas F?rber wrote: > Am 24.08.2012 17:35, schrieb malc: > > On Fri, 24 Aug 2012, malc wrote: > > > >> On Fri, 24 Aug 2012, Aurelien Jarno wrote: > >> > >>> On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > >

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, malc wrote: > On Fri, 24 Aug 2012, Aurelien Jarno wrote: > > > On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: [..snip..] > > - On 32 bit hosts, which usually need register alignments for 64-bit > > values (at least on arm and mips),

Re: [Qemu-devel] [PATCH 2/5] softmmu templates: optionally pass CPUState to memory access functions

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Aurelien Jarno wrote: > On Sun, Mar 11, 2012 at 10:24:03PM +, Blue Swirl wrote: > > Optionally, make memory access helpers take a parameter for CPUState > > instead of relying on global env. > > > > On most targets, perform simple moves to reorder registers. On i386, > >

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: > On 2012-08-24 14:02, malc wrote: > > On Fri, 24 Aug 2012, Jan Kiszka wrote: > > > >> On 2012-08-24 05:58, malc wrote: > >>> On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > >>> > >>>

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-24 Thread malc
On Fri, 24 Aug 2012, Jan Kiszka wrote: > On 2012-08-24 05:58, malc wrote: > > On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > > > >> After applying this version 2 of this patch series, I can > >> successfully run "Micoport UNIX System V/386, v 2.1" (ca

Re: [Qemu-devel] [PATCH v2 0/6] Running Microport UNIX (ca 1987)

2012-08-23 Thread malc
On Thu, 23 Aug 2012, Matthew Ogilvie wrote: > After applying this version 2 of this patch series, I can > successfully run "Micoport UNIX System V/386, v 2.1" (ca 1987) > under qemu. (although not if I try to enable KVM) > > Version 1 of this series was posted about 4 weeks ago. See > http://pa

Re: [Qemu-devel] [RESEND][PATCH for 1.2] audio: Make pcspk card selectable again

2012-08-16 Thread malc
On Thu, 16 Aug 2012, Jan Kiszka wrote: > Since we moved pcspk into hwlib, CONFIG_PCSPK is no longer defined per > target. Therefore, statically built soundhw array in arch_init.c stopped > including this card. > > Work around this by re-adding this define to config-target.mak. > Long-term, a dyna

Re: [Qemu-devel] [PATCH] Fix ALSA configure check

2012-07-31 Thread malc
On Tue, 31 Jul 2012, Paul Brook wrote: > Recent gcc notice that the ASLA configure check uses an uninitialized > variable, causing spurious failures. Adjust the testcase to avoid this. http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02704.html > > Signed-off-by: Paul Brook > --- >

Re: [Qemu-devel] [PATCH 2/3] target-i386/translate.c: mov to/from crN/drN: ignore mod bits

2012-07-27 Thread malc
On Fri, 27 Jul 2012, Matthew Ogilvie wrote: > Microport UNIX System V/386 v 2.1 (ca 1987) uses mod R/M bytes for > the control register mov instructions where the mod bits are 0, > even though the 80386 spec claims they are "always" 1's. The fact > that it ran at all clearly indicates the real ch

Re: [Qemu-devel] [PATCH] alsa: fix configure detection of alsa

2012-07-20 Thread malc
On Fri, 20 Jul 2012, Anthony Liguori wrote: > Handle is uninitialized which causes the configure check to fail. > http://patchwork.ozlabs.org/patch/171688/ Has an advantage of not expecting alsa/asoundlib.h including stddef.h > Cc: malc > Signed-off-by: Anthony Liguori > -

Re: [Qemu-devel] [PATCH] audio: Make PC speaker audio card available by default

2012-07-19 Thread malc
efault-configs/${ARCH}.mak to enable it > and indeed, it's enabled by default for a bunch of targets including x86_64. > > So... I'm confused what this is fixing. Since I suspect malc and Jan are > asleep, I'm going to revert for now to fix the build. [..snip..] [1]

Re: [Qemu-devel] [PATCH] audio: Make PC speaker audio card available by default

2012-07-19 Thread malc
On Thu, 19 Jul 2012, Jan Kiszka wrote: > Signed-off-by: Jan Kiszka > --- > configure |4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > Applied, thanks. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-15 Thread malc
On Sun, 15 Jul 2012, agraham wrote: [..snip..] > > I've found the root cause and hopefully you should be able to reproduce the > issue. > > There was a configure option introduced called "--enable-mixemu". > > --enable-mixemu enable mixer emulation Try this diff --git a/audio/audio.

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-15 Thread malc
On Sun, 15 Jul 2012, agraham wrote: > On 07/15/2012 12:21 AM, malc wrote: > > On Sun, 15 Jul 2012, agraham wrote: > > > > > On 07/15/2012 12:01 AM, malc wrote: > > > > On Sat, 14 Jul 2012, agraham wrote: > > > > > > > > [..snip..]

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-14 Thread malc
On Sat, 14 Jul 2012, agraham wrote: [..snip..] > > Just to confirm, I'm connecting via a TCP INET socket (i.e. server and client > are different machines), your acap.ml script also allows unix: sockets, which > one are you using? > The default, TCP. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-14 Thread malc
On Sun, 15 Jul 2012, agraham wrote: > On 07/15/2012 12:01 AM, malc wrote: > > On Sat, 14 Jul 2012, agraham wrote: > > > > [..snip..] > > > > > > > > /usr/bin/qemu-kvm -usb -no-fd-bootchk -M pc -enable-kvm -m 128 -drive > > > file=/Storag

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-14 Thread malc
On Sat, 14 Jul 2012, agraham wrote: [..snip..] > > /usr/bin/qemu-kvm -usb -no-fd-bootchk -M pc -enable-kvm -m 128 -drive > file=/Storage/Windows/Images/Clone_of_Windows-XP-x32,if=none,media=disk,cache=unsafe,aio=native,snapshot,format=qcow2,id=virtio-blk-pci0 > -device virtio-blk-pci,addr=0x05,b

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-14 Thread malc
On Sat, 14 Jul 2012, agraham wrote: > On 07/14/2012 09:09 PM, malc wrote: > > On Sat, 14 Jul 2012, agraham wrote: > > > > > On 07/14/2012 06:20 PM, malc wrote: > > > > On Sat, 14 Jul 2012, agraham wrote: > > > > > > > > > On 07/14/2

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-14 Thread malc
On Sat, 14 Jul 2012, agraham wrote: > On 07/14/2012 06:20 PM, malc wrote: > > On Sat, 14 Jul 2012, agraham wrote: > > > > > On 07/14/2012 01:55 PM, agraham wrote: > > > > On 07/14/2012 11:44 AM, malc wrote: > > > > > On Sat, 14 Jul 2012, agrah

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-14 Thread malc
On Sat, 14 Jul 2012, agraham wrote: > On 07/14/2012 01:55 PM, agraham wrote: > > On 07/14/2012 11:44 AM, malc wrote: > > > On Sat, 14 Jul 2012, agraham wrote: [..snip.]] > > > > I've just rebuilt QEMU 1.0 (and all of its dependencies) and it has > > >

Re: [Qemu-devel] QEMU VNC Audio - All audio data null

2012-07-14 Thread malc
On Sat, 14 Jul 2012, agraham wrote: > On 07/14/2012 03:17 AM, agraham wrote: > > Hi Guys, > > > > I've written a VNC client that implements the VNC QEMU Audio extensions. > > Using QEMU 0.13 it works very very for remote sound, however after > > upgrading to QEMU 1.1.0 the audio stream contains o

Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

2012-06-25 Thread malc
On Mon, 25 Jun 2012, Peter Maydell wrote: > Add field32() and field64() functions which extract a particular > bit field from a word and return it. Based on an idea by Jia Liu. > > Suggested-by: Jia Liu > Signed-off-by: Peter Maydell > --- [..snip..] > +static inline uint64_t field64(uint64_t

Re: [Qemu-devel] [PATCH] TCG: Fix compile breakage in tcg_dump_ops

2012-06-23 Thread malc
On Sun, 24 Jun 2012, Alexander Graf wrote: > Commit eeacee4d865 changed the syntax of tcg_dump_ops, but didn't convert > all users (notably missing the ppc ones) to it. Fix them to the new syntax. Applied. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] qcow2: Silence false warning

2012-06-15 Thread malc
On Fri, 15 Jun 2012, Kevin Wolf wrote: > Some gcc versions seem not to be able to figure out that the switch > statement covers all possible values and that c is therefore always > initialised. Add a default branch for them. > Applied, thanks. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 1.1] es1370: Fix debug code

2012-05-28 Thread malc
ces?: > > > hw/es1370.c:414: warning: format ?%d? expects type ?int?, but argument 3 > > > has type ?size_t? > > The unicode quotes in this commit message seem to have got smashed to > > question-mark characters at some point between this email and it hitting > > g

Re: [Qemu-devel] [PATCH for-1.1 v2] tcg/ppc: Handle _CALL_DARWIN being undefined on Darwin

2012-05-27 Thread malc
On Sun, 27 May 2012, Andreas F?rber wrote: > powerpc-apple-darwin9-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5577) > does not define _CALL_DARWIN, leading to unexpected behavior w.r.t. > register clobbering and stack frame layout. > > Since _CALL_DARWIN is a reserved identifier, define a custom > T

Re: [Qemu-devel] [PATCH 04/10] qom: add get_id

2012-05-25 Thread malc
On Fri, 25 May 2012, Andreas F?rber wrote: > Am 23.05.2012 17:44, schrieb Paolo Bonzini: > > Some classes may present objects differently in errors, for example if they > > are not part of the composition tree or if they are not assigned an id by > > the user. Let them do this with a get_id metho

Re: [Qemu-devel] [PATCH v2] audio: Always call fini on exit

2012-05-24 Thread malc
On Thu, 24 May 2012, Jan Kiszka wrote: > Not only clean up enabled voices but any registered one. Backends like > pulsaudio rely on unconditional fini handler invocations. > > This fixes "Memory pool destroyed but not all memory blocks freed!" > warnings on VM shutdowns when pa is used and lockup

Re: [Qemu-devel] [PATCH 1.1] es1370: Fix debug code

2012-05-23 Thread malc
On Wed, 23 May 2012, Stefan Weil wrote: > When DEBUG_ES1370 is defined, the compiler shows these warnings: > [..snip..] Thanks, applied. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH] audio: split IN_T into two separate constants

2012-05-18 Thread malc
On Fri, 18 May 2012, Roger Pau Monne wrote: > Split IN_T into BSIZE and ITYPE, to avoid expansion if the OS has > defined macros for the intX_t and uintX_t types. The IN_T constant is > then defined in mixeng_template.h so it can be used by the > functions/macros on this header file. > > This cha

Re: [Qemu-devel] [PATCH for-1.1 0/2] tcg/ppc64: AREG0 support

2012-05-14 Thread malc
On Mon, 14 May 2012, Andreas F?rber wrote: > Am 12.05.2012 03:16, schrieb Andreas F?rber: > > Here's patches to optimize and fix potential AREG0 issues on ppc64. > > > > So far I've only tested on Darwin/ppc64 - Debian/sparc, HelenOS/sparc64, > > Haiku/i386, Haiku/x86_64 guests work. > > I've no

Re: [Qemu-devel] [PATCH] audio: fix bug in mixeng_template.h build on NetBSD

2012-05-14 Thread malc
On Mon, 14 May 2012, Roger Pau Monne wrote: > malc escribi?: > > On Fri, 11 May 2012, Roger Pau Monne wrote: > > > > > This is a bug fix for rc1, although I think this bug has been present > > > for a long time. > > > > If there's a bug t

Re: [Qemu-devel] [PATCH for-1.1 0/2] tcg/ppc64: AREG0 support

2012-05-12 Thread malc
On Sat, 12 May 2012, Andreas F?rber wrote: > Hello malc and Alex, > > Here's patches to optimize and fix potential AREG0 issues on ppc64. > > So far I've only tested on Darwin/ppc64 - Debian/sparc, HelenOS/sparc64, > Haiku/i386, Haiku/x86_64 guests work. > S

Re: [Qemu-devel] [PATCH] audio: fix bug in mixeng_template.h build on NetBSD

2012-05-11 Thread malc
On Fri, 11 May 2012, Roger Pau Monne wrote: > This is a bug fix for rc1, although I think this bug has been present > for a long time. If there's a bug than it's within NetBSD itself, this issue has been discussed few times (at least twice it hink) in the past, please search the ML archives. [..

Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit

2012-05-09 Thread malc
On Wed, 9 May 2012, Jan Kiszka wrote: > On 2012-05-03 20:51, malc wrote: > > On Thu, 3 May 2012, Jan Kiszka wrote: > > > >> On 2012-05-03 16:32, malc wrote: > >>> On Thu, 3 May 2012, Jan Kiszka wrote: > >>> > >>>> Not onl

Re: [Qemu-devel] [PATCH v3 for-1.1-rc1 4/4] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-09 Thread malc
On Wed, 9 May 2012, Andreas F?rber wrote: > Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3, > based on patches by malc. > > Also adjust the registers clobbered, based on patch by Alex. ppc64 is similarly broken in pass areg0 case. [..snip..] -- mailto:av1...@comtv.ru

Re: [Qemu-devel] qemu-1.0-rc1 delayed (need fix for PPC32 build)

2012-05-08 Thread malc
ng of the situation: > > 1) TCG changes were made for the Sparc/Alpha targets that use AREG0 > > 2) AREG0 never worked properly on ppc32 hosts > > 3) Until recently, this caused a runtime failure of the Sparc/Alpha targets on > ppc32. However, malc recently changed this to a

Re: [Qemu-devel] [PATCH v2 for-1.1 4/4] tcg/ppc: Fix CONFIG_TCG_PASS_AREG0 mode

2012-05-08 Thread malc
On Wed, 9 May 2012, Andreas F?rber wrote: > Adjust the tcg_out_qemu_{ld,st}() slow paths to pass AREG0 in r3, > based on patches by malc. > > Also adjust the registers clobbered, based on patch by Alex. Alexander, my head is splitting now, so i can not calculate things inside i

Re: [Qemu-devel] [PATCH v2 for-1.1 0/4] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Wed, 9 May 2012, Andreas F?rber wrote: > Hello malc, > > Here's an updated series to fix AREG0 and ppc build. > > Debian/sparc fsck on Darwin/ppc now succeeds. No regressions noticed with > Debian/sparc, HelenOS/sparc64, Haiku/i386, Haiku/x86_64. > > Regards,

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Wed, 9 May 2012, malc wrote: > On Tue, 8 May 2012, Andreas F?rber wrote: > > > Am 08.05.2012 22:28, schrieb malc: > > > On Tue, 8 May 2012, Andreas F?rber wrote: > > > > > >> What about the following? (untested) > > > > > > I&#x

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Andreas F?rber wrote: > Am 08.05.2012 22:28, schrieb malc: > > On Tue, 8 May 2012, Andreas F?rber wrote: > > > >> What about the following? (untested) > > > > I'd much rather have the ifdefery scattered around the code than >

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Andreas F?rber wrote: > Am 08.05.2012 21:42, schrieb Alexander Graf: > > > > On 08.05.2012, at 21:29, Andreas F?rber wrote: > > > >> On patch 3/3 he didn't like my alignment macro. I don't have a better > >> one though, suggestions or patches welcome. Ideal might be some > >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Andreas F?rber wrote: > Am 08.05.2012 19:39, schrieb malc: > > On Tue, 8 May 2012, Alexander Graf wrote: > > > >> > >> On 07.05.2012, at 01:46, Andreas F?rber wrote: > >> > >>> Hello malc, > >>> > >&

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-1.1 0/3] tcg/ppc: AREG0 support and Darwin fixes

2012-05-08 Thread malc
On Tue, 8 May 2012, Alexander Graf wrote: > > On 07.05.2012, at 01:46, Andreas F?rber wrote: > > > Hello malc, > > > > This series fixes two long-standing issues on Darwin/ppc and, based on your > > second patch, fixes the AREG0 mode for Linux and D

Re: [Qemu-devel] [RFC] tcg/ppc: Do not overwrite lower address word on Darwin and AIX

2012-05-06 Thread malc
On Sun, 6 May 2012, Andreas F?rber wrote: > For targets where TARGET_LONG_BITS != 32, i.e. 64-bit guests, > addr_reg is moved to r4. For hosts with TCG_TARGET_CALL_ALIGN_ARGS > either data_reg2 or data_reg or a masked version thereof would overwrite > r4. Place it in r5 instead, matching TCG_TARGE

Re: [Qemu-devel] sparc-softmmu uninitialized memory read?

2012-05-06 Thread malc
On Sun, 6 May 2012, Andreas F?rber wrote: > Am 06.05.2012 18:44, schrieb Blue Swirl: > > On Sun, May 6, 2012 at 2:02 PM, Andreas F?rber wrote: > >> Am 06.05.2012 13:32, schrieb Blue Swirl: > >>> On Sat, May 5, 2012 at 3:37 PM, Andreas F?rber wrote: > Hello Blue, [..snip..] > Great! I have

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)

2012-05-06 Thread malc
On Sun, 6 May 2012, Blue Swirl wrote: > On Sun, May 6, 2012 at 10:17 AM, malc wrote: > > On Sun, 6 May 2012, Blue Swirl wrote: > > > >> On Sun, May 6, 2012 at 9:46 AM, malc wrote: > >> > On Sun, 6 May 2012, Blue Swirl wrote: > >> > >

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)

2012-05-06 Thread malc
On Sun, 6 May 2012, Blue Swirl wrote: > On Sun, May 6, 2012 at 9:46 AM, malc wrote: > > On Sun, 6 May 2012, Blue Swirl wrote: > > > >> On Sun, May 6, 2012 at 9:03 AM, malc wrote: > >> > On Sun, 6 May 2012, Blue Swirl wrote: > >> > >

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)

2012-05-06 Thread malc
On Sun, 6 May 2012, Blue Swirl wrote: > On Sun, May 6, 2012 at 9:03 AM, malc wrote: > > On Sun, 6 May 2012, Blue Swirl wrote: > > > >> On Fri, May 4, 2012 at 2:37 AM, malc wrote: > >> > On Fri, 4 May 2012, Andreas F?rber wrote: > >> > >

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)

2012-05-06 Thread malc
On Sun, 6 May 2012, Blue Swirl wrote: > On Fri, May 4, 2012 at 2:37 AM, malc wrote: > > On Fri, 4 May 2012, Andreas F?rber wrote: > > > >> Am 04.05.2012 02:41, schrieb Anthony Liguori: > >> > On 05/03/2012 02:58 PM, Peter Maydell wrote: > >> >&g

Re: [Qemu-devel] [PATCH] fix build with pulseaudio versions older than 0.9.11

2012-05-04 Thread malc
On Thu, 3 May 2012, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > audio/paaudio.c | 30 +- > 1 files changed, 29 insertions(+), 1 deletions(-) > [..snip..] Thanks, applied. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] unreviewed commits (was: Re: Restore consistent formatting)

2012-05-03 Thread malc
On Fri, 4 May 2012, Andreas F?rber wrote: > Am 04.05.2012 02:41, schrieb Anthony Liguori: > > On 05/03/2012 02:58 PM, Peter Maydell wrote: > >> On 9 February 2012 13:46, Anthony Liguori wrote: > >>> On 02/09/2012 03:48 AM, Markus Armbruster wrote: > You buried the one truly important sentenc

Re: [Qemu-devel] [PATCH 1.1] audio: Always call fini on exit

2012-05-03 Thread malc
On Thu, 3 May 2012, Jan Kiszka wrote: > On 2012-05-03 16:32, malc wrote: > > On Thu, 3 May 2012, Jan Kiszka wrote: > > > >> Not only clean up enabled voices but any registered one. Backends like > >> pulsaudio rely on unconditional fini handler invocations.

  1   2   3   4   5   6   7   8   >