> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Wednesday, November 12, 2014 4:33 PM
> To: SeokYeon Hwang
> Cc: qemu-devel@nongnu.org; kongjian...@gmail.com; paolo.bonz...@gmail.com;
> mre...@redhat.com; qemu-triv...@nongnu.org;
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Monday, November 10, 2014 10:21 PM
> To: SeokYeon Hwang
> Cc: kongjian...@gmail.com; paolo.bonz...@gmail.com; qemu-devel@nongnu.org;
> mre...@redhat.com
> Subject: Re: [Qemu-devel] [PATCH
Added 'assert(os_errno >= 0)' in 'error_set_errno()'.
Signed-off-by: SeokYeon Hwang
---
util/error.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/util/error.c b/util/error.c
index 2ace0d8..6c9d995 100644
--- a/util/error.c
+++ b/util/error.c
@@ -62,6 +62,7 @@ voi
Signed-off-by: SeokYeon Hwang
---
hw/pci/pcie.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c
index 58455bd..2902f7d 100644
--- a/hw/pci/pcie.c
+++ b/hw/pci/pcie.c
@@ -229,7 +229,7 @@ static void pcie_cap_slot_hotplug_common(PCIDevice
> -Original Message-
> From: Eric Blake [mailto:ebl...@redhat.com]
> Sent: Tuesday, November 11, 2014 1:14 AM
> To: SeokYeon Hwang; qemu-devel@nongnu.org
> Cc: paolo.bonz...@gmail.com; arm...@redhat.com; mre...@redhat.com;
> kongjian...@gmail.com
> Subject: Re: [PATCH
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Monday, November 10, 2014 6:33 PM
> To: SeokYeon Hwang
> Cc: qemu-devel@nongnu.org; kongjian...@gmail.com; paolo.bonz...@gmail.com;
> mre...@redhat.com
> Subject: Re: [Qemu-devel] [PATCH
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Friday, November 07, 2014 4:45 PM
> To: SeokYeon Hwang
> Cc: 'Michael S. Tsirkin'; 'Paolo Bonzini'; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] pci: fixe
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Friday, November 07, 2014 4:41 PM
> To: Amos Kong
> Cc: SeokYeon Hwang; mre...@redhat.com; paolo.bonz...@gmail.com; qemu-
> de...@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH v2] erro
Added 'assert(os_errno > 0)' in 'error_set_errno()'.
Fixed errno since it passes wrong value to 'error_set_errno()'.
Signed-off-by: SeokYeon Hwang
---
hw/pci/pcie.c | 2 +-
util/error.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Thursday, November 06, 2014 6:24 PM
> To: SeokYeon Hwang
> Cc: 'Paolo Bonzini'; 'Markus Armbruster'; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] pci: fixe
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Thursday, November 06, 2014 6:25 PM
> To: SeokYeon Hwang
> Cc: 'Paolo Bonzini'; 'Max Reitz'; qemu-devel@nongnu.org; Peter Maydell;
> paolo.bonz...@gmail.com
> Subje
Added 'assert(os_errno > 0)' in 'error_set_errno()'.
Fixed errno since it passes wrong value to 'error_set_errno()'.
Signed-off-by: SeokYeon Hwang
---
hw/pci/pcie.c | 2 +-
util/error.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Thursday, November 06, 2014 6:17 PM
> To: SeokYeon Hwang
> Cc: qemu-devel@nongnu.org; aneesh.ku...@linux.vnet.ibm.com;
> pbonz...@redhat.com; Peter Maydell
> Subject: Re: [PATCH]
> -Original Message-
> From: Markus Armbruster [mailto:arm...@redhat.com]
> Sent: Thursday, November 06, 2014 6:21 PM
> To: SeokYeon Hwang
> Cc: 'Paolo Bonzini'; 'Michael S. Tsirkin'; qemu-devel@nongnu.org
> Subject: Re: [Qemu-devel] [PATCH] pci: fixe
> -Original Message-
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Wednesday, November 05, 2014 11:55 PM
> To: Michael S. Tsirkin
> Cc: Markus Armbruster; SeokYeon Hwang; qemu-devel@nongnu.org
> Subject: Re: [Qemu-deve
> -Original Message-
> From: SeokYeon Hwang [mailto:syeon.hw...@samsung.com]
> Sent: Wednesday, November 05, 2014 10:13 PM
> To: 'Paolo Bonzini'; 'Max Reitz'; 'qemu-devel@nongnu.org'
> Cc: 'arm...@redhat.com'; 'paolo.bonz...@gm
Please review this patch.
Thanks.
> -Original Message-
> From: SeokYeon Hwang [mailto:syeon.hw...@samsung.com]
> Sent: Friday, October 31, 2014 5:04 PM
> To: qemu-devel@nongnu.org
> Cc: aneesh.ku...@linux.vnet.ibm.com; SeokYeon Hwang
> Subject: [PATCH] 9pfs: changed to
> -Original Message-
> From: Michael S. Tsirkin [mailto:m...@redhat.com]
> Sent: Wednesday, November 05, 2014 9:46 PM
> To: SeokYeon Hwang
> Cc: qemu-devel@nongnu.org; arm...@redhat.com; pbonz...@redhat.com
> Subject: Re: [PATCH] pci: fixed mismatch of erro
> -Original Message-
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Wednesday, November 05, 2014 9:45 PM
> To: Max Reitz; SeokYeon Hwang; qemu-devel@nongnu.org
> Cc: arm...@redhat.com; paolo.bonz...@gmail.com
> Subject: Re:
() thinks that error is
occured and makes the device unregistered. Nevertheless, qdev thinks that
device is realized.
Finally, crash is occured by commands like 'qtree' that traverse qdev list.
So, pci_qdev_init() returns -1 when init function returns not 0.
Signed-off-by: SeokYeon Hwan
Negative type of errno like -ERRNO is used a lot by developers. Therefore,
error_set_errno() is modified to deal with a negative type of os_error.
(Negative type is used at pcie_cap_slot_hotplug_common() in hw/pci/pcie.c)
Signed-off-by: SeokYeon Hwang
---
util/error.c | 2 +-
1 file changed, 1
Some of variables handling 64bit address must be changed from 'ram_addr_t' to
'uint64_t'.
Signed-off-by: SeokYeon Hwang
---
hw/i386/smbios.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index 8a7ad48..024
> -Original Message-
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Tuesday, November 04, 2014 5:42 PM
> To: SeokYeon Hwang; qemu-devel@nongnu.org
> Cc: paolo.bonz...@gmail.com; arm...@redhat.com; alex.william...@hp.com
> S
"smbios_build_type_17_table()" should take 'uint64_t' instead of 'ram_addr_t'
because it should be able to handle (16ll * GiB).
Otherwise, clang (>= 3.4) produces compilation warning in "smbios_get_tables()".
Signed-off-by: SeokYeon Hwang
---
> -Original Message-
> From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo
> Bonzini
> Sent: Tuesday, November 04, 2014 1:16 AM
> To: SeokYeon Hwang; qemu-devel@nongnu.org
> Cc: arm...@redhat.com; alex.william...@hp.com
> Subject: Re: [PATCH] s
I posted a new patch which your suggestion is applied.
Thanks.
> -Original Message-
> From: Peter Maydell [mailto:peter.mayd...@linaro.org]
> Sent: Saturday, November 01, 2014 3:30 AM
> To: SeokYeon Hwang
> Cc: QEMU Developers
> Subject: Re: [Qemu-devel] [PATCH] tran
Marked map_exec() with the 'unused' attribute to avoid '-Wunused-function' on
clang 3.4 or later.
Signed-off-by: SeokYeon Hwang
---
translate-all.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/translate-all.c b/translate-all.c
index ba5c840..
Moved map_exec() and wrapped it in #ifdef to avoid "-Wunused-function" on clang
3.4 or later.
Signed-off-by: SeokYeon Hwang
---
translate-all.c | 52 +++-
1 file changed, 27 insertions(+), 25 deletions(-)
diff --git a/translate-all.c b
Changed to use event_notifier instead of qemu_pipe.
It is necessary for porting 9pfs to Windows and MacOS.
Signed-off-by: SeokYeon Hwang
---
hw/9pfs/virtio-9p-coth.c | 29 +++--
hw/9pfs/virtio-9p-coth.h | 4 ++--
2 files changed, 9 insertions(+), 24 deletions(-)
diff
Explicit casting to 'ram_addr_t' in order to avoid "-Wconstant-conversion" on
clang 3.4 or later.
Signed-off-by: SeokYeon Hwang
---
hw/i386/smbios.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c
index e3fa1b2..ace
To fix compiler warning on clang > 3.4, changed to proper enum type.
Signed-off-by: SeokYeon Hwang
---
block.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/block.c b/block.c
index 88f6d9b..50845a4 100644
--- a/block.c
+++ b/block.c
@@ -3540,10 +3540,10 @@ sta
Wrapped uuid_unparse() in #ifdef to avoid "-Wunused-function" on clang 3.4 or
later.
Signed-off-by: SeokYeon Hwang
---
block/vdi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/block/vdi.c b/block/vdi.c
index 19701ee..e1d211c 100644
--- a/block/vdi.c
+++ b/block/vdi.c
When I check it the latest master branch, the issue is already resolved.
It is resolved by commit 5942a19040fed313b316ab7b6e3d2d8e7b1625bb (28,
June).
I'm sorry and thank you for your help.
> On Thu, Jun 26, 2014 at 12:48:14PM +0900, SeokYeon Hwang wrote:
> > > On Wed, 2014-06-
> On Wed, 2014-06-25 at 15:03 +0300, Michael S. Tsirkin wrote:
> > On Wed, Jun 25, 2014 at 06:59:08PM +0900, SeokYeon Hwang wrote:
> > > In case of the unrealized "pdev", memory can be illegally accessed and
> corrupted.
> > >
In case of the unrealized "pdev", memory can be illegally accessed and
corrupted.
Refer to device_unparent() in the commit
5c21ce77d7e5643089ceec556c0408445d017f32.
Change-Id: Iacb195a092c86d4c677ad0404582af104b2251ae
Signed-off-by: SeokYeon Hwang
---
hw/pci/pci.c | 7 ++-
1 fi
35 matches
Mail list logo
